Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tup-712 "Username" not "User Name" #453

Merged
merged 2 commits into from
Apr 29, 2024
Merged

fix: tup-712 "Username" not "User Name" #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95175ac
fix: tup-712 "Username" not "User Name"
wesleyboar Apr 11, 2024
0170db7
test: tup-712 "Username" not "User Name"
wesleyboar Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/tup-components/src/auth/LoginComponent/LoginComponent.spec.tsx
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarosenb Are tests for static form label text helpful? I'm tempted to delete these…

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('LoginComponent', () => {
value: { replace: mockNavigate },
});
const { getByLabelText, getByRole } = testRender(<LoginComponent />);
const username = getByLabelText(/User Name/);
const username = getByLabelText(/Username/);
const password = getByLabelText(/Password/);
const submit = getByRole('button');
await act(async () => {
Expand All @@ -50,7 +50,7 @@ describe('LoginComponent', () => {
const { getByLabelText, getByRole, getAllByText } = testRender(
<LoginComponent />
);
const username = getByLabelText(/User Name/);
const username = getByLabelText(/Username/);
const password = getByLabelText(/Password/);
const submit = getByRole('button');
await act(async () => {
Expand Down Expand Up @@ -79,7 +79,7 @@ describe('LoginComponent', () => {
const { getByLabelText, getByRole, getAllByText } = testRender(
<LoginComponent />
);
const username = getByLabelText(/User Name/);
const username = getByLabelText(/Username/);
const password = getByLabelText(/Password/);
const submit = getByRole('button');
await act(async () => {
Expand Down
2 changes: 1 addition & 1 deletion libs/tup-components/src/auth/LoginComponent/LoginComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const LoginComponent: React.FC<LoginProps> = ({ className }) => {
<LoginError status={status} isError={isError} />
<FormikInput
name="username"
label="User Name"
label="Username"
type="text"
autoComplete="username"
required
Expand Down