Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tup-712 "Username" not "User Name" #453

Merged
merged 2 commits into from Apr 29, 2024

Conversation

wesleyboar
Copy link
Member

Overview / Changes

Update TACC login form to display "Username" not "User Name".

Related

Testing / UI

before after
before after

@wesleyboar wesleyboar changed the title Fix/tup 712 username not user name fix: tup-712 "Username" not "User Name" Apr 11, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarosenb Are tests for static form label text helpful? I'm tempted to delete these…

Copy link
Collaborator

@van-go van-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleyboar wesleyboar merged commit 2473e1b into main Apr 29, 2024
1 check passed
@wesleyboar wesleyboar deleted the fix/tup-712-username-not-user-name branch April 29, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants