Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TUP-700 @tacc/core-components - storybook (replaced by #462) #435

Commits on Feb 26, 2024

  1. feat: tup-700 storybook

    STEPS
    1. `npm add -D @nx/storybook@17.2.8`
    2. `npx nx@17.2.8 g @nx/storybook:configuration core-components --uiFramework="@storybook/react-vite" --bundler="vite"`
    3. "Do you want to set up Storybook interaction tests? (Y/n) ›  false"
    
    CONCERNS
    1. Generator installed `@swc-node/register` and `@swc/core`.
    2. `@vitejs/plugin-react-swc` is already isntalled.
    3. [Storybook 7 does not work with @vitejs/plugin-react-swc](storybookjs/storybook#22381)
    4. I worry I cannot move to Storybook 8 via NX, because it requires NX v18.
    wesleyboar committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    41c6cfd View commit details
    Browse the repository at this point in the history
  2. deps: tup-700 uninstall @swc-…

    - Vite already uses `@vitejs/plugin-react-swc` (notice the SWC).
    - Storybook seems to work fine without these.
    - I read that in v8, Storybook will stop isntalling backup compilers.
    wesleyboar committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    4820882 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c834b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9d1a4df View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    a6b19de View commit details
    Browse the repository at this point in the history
  2. feat: tup-700 button story

    wesleyboar committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ba5f295 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. style: npx nx format:write

    wesleyboar committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c474e5f View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'feat/TUP-700-core-components-node-pkg' into feat/TUP-70…

    …0-core-components-node-pkg--storybook
    wesleyboar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f3bdb30 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feat/TUP-700-core-components-node-pkg' into feat/TUP-70…

    …0-core-components-node-pkg--storybook
    wesleyboar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    a3c0117 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feat/TUP-700-core-components-node-pkg' into feat/TUP-70…

    …0-core-components-node-pkg--storybook
    wesleyboar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c92aec1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d6bd44c View commit details
    Browse the repository at this point in the history
  5. fix: tup-700 npm ci core-components workspace ★

    Running npm ci at this point:
    - DOES reinstall deps
    - does NOT create libs/core-components/node_modules
    - does NOT create libs/core-components/package-lock.json
    wesleyboar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    977f3d0 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e83f3b7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    239338c View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    63307c3 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    faa8d23 View commit details
    Browse the repository at this point in the history
  2. npx nx format:write

    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c82c00b View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1f3197d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e142d04 View commit details
    Browse the repository at this point in the history
  5. docs: do not reference lib names

    This causes more work when renaming a library.
    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ab245f8 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c24ca96 View commit details
    Browse the repository at this point in the history
  7. docs: do reference (other) lib names

    These references are outside of this lib, so yeah, reference lib name.
    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cf2e929 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ef151e5 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…

    …eat/TUP-700-core-components-node-pkg--storybook
    wesleyboar committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6234e49 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d84cdf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f562b89 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    46c9d2c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c445495 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3db236e View commit details
    Browse the repository at this point in the history
  7. chore: (redundantly) include optional dependences

    Optional dependencies are installed by default.
    
    We can not disable "install optional by default", cuz NX will fail:
    nrwl/nx#20617
    
    We can not configure NPM to omit optional deps only per workspace, cuz:
    npm/cli#6099
    wesleyboar committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5fced48 View commit details
    Browse the repository at this point in the history
  8. fix: limit install overhead for core-components

    For core-components, tell dev to only install for core-components.
    wesleyboar committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d486557 View commit details
    Browse the repository at this point in the history
  9. fix: add missing dependencies for core-components

    All this change was required to run `npx nx serve core-components`.
    wesleyboar committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ab27f19 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    3a1bcd7 View commit details
    Browse the repository at this point in the history
  2. fix: a TypeScript lint error

    Error occurred as red squiggly udnerline in code editor when importing a component from within a component.
    wesleyboar committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3443beb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    43f8c99 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    904200a View commit details
    Browse the repository at this point in the history