-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TUP-700 @tacc/core-components - storybook (replaced by #462) #435
feat: TUP-700 @tacc/core-components - storybook (replaced by #462) #435
Commits on Feb 26, 2024
-
STEPS 1. `npm add -D @nx/storybook@17.2.8` 2. `npx nx@17.2.8 g @nx/storybook:configuration core-components --uiFramework="@storybook/react-vite" --bundler="vite"` 3. "Do you want to set up Storybook interaction tests? (Y/n) › false" CONCERNS 1. Generator installed `@swc-node/register` and `@swc/core`. 2. `@vitejs/plugin-react-swc` is already isntalled. 3. [Storybook 7 does not work with @vitejs/plugin-react-swc](storybookjs/storybook#22381) 4. I worry I cannot move to Storybook 8 via NX, because it requires NX v18.
Configuration menu - View commit details
-
Copy full SHA for 41c6cfd - Browse repository at this point
Copy the full SHA 41c6cfdView commit details -
deps: tup-700 uninstall
@swc-…
- Vite already uses `@vitejs/plugin-react-swc` (notice the SWC). - Storybook seems to work fine without these. - I read that in v8, Storybook will stop isntalling backup compilers.
Configuration menu - View commit details
-
Copy full SHA for 4820882 - Browse repository at this point
Copy the full SHA 4820882View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c834b7 - Browse repository at this point
Copy the full SHA 4c834b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d1a4df - Browse repository at this point
Copy the full SHA 9d1a4dfView commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6b19de - Browse repository at this point
Copy the full SHA a6b19deView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba5f295 - Browse repository at this point
Copy the full SHA ba5f295View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c474e5f - Browse repository at this point
Copy the full SHA c474e5fView commit details
Commits on May 8, 2024
-
Merge branch 'feat/TUP-700-core-components-node-pkg' into feat/TUP-70…
…0-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for f3bdb30 - Browse repository at this point
Copy the full SHA f3bdb30View commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg' into feat/TUP-70…
…0-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for a3c0117 - Browse repository at this point
Copy the full SHA a3c0117View commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg' into feat/TUP-70…
…0-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for c92aec1 - Browse repository at this point
Copy the full SHA c92aec1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6bd44c - Browse repository at this point
Copy the full SHA d6bd44cView commit details -
fix: tup-700 npm ci core-components workspace ★
Running npm ci at this point: - DOES reinstall deps - does NOT create libs/core-components/node_modules - does NOT create libs/core-components/package-lock.json
Configuration menu - View commit details
-
Copy full SHA for 977f3d0 - Browse repository at this point
Copy the full SHA 977f3d0View commit details
Commits on May 9, 2024
-
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for e83f3b7 - Browse repository at this point
Copy the full SHA e83f3b7View commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for 239338c - Browse repository at this point
Copy the full SHA 239338cView commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for 63307c3 - Browse repository at this point
Copy the full SHA 63307c3View commit details
Commits on May 10, 2024
-
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for faa8d23 - Browse repository at this point
Copy the full SHA faa8d23View commit details -
Configuration menu - View commit details
-
Copy full SHA for c82c00b - Browse repository at this point
Copy the full SHA c82c00bView commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for 1f3197d - Browse repository at this point
Copy the full SHA 1f3197dView commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for e142d04 - Browse repository at this point
Copy the full SHA e142d04View commit details -
docs: do not reference lib names
This causes more work when renaming a library.
Configuration menu - View commit details
-
Copy full SHA for ab245f8 - Browse repository at this point
Copy the full SHA ab245f8View commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for c24ca96 - Browse repository at this point
Copy the full SHA c24ca96View commit details -
docs: do reference (other) lib names
These references are outside of this lib, so yeah, reference lib name.
Configuration menu - View commit details
-
Copy full SHA for cf2e929 - Browse repository at this point
Copy the full SHA cf2e929View commit details -
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for ef151e5 - Browse repository at this point
Copy the full SHA ef151e5View commit details
Commits on May 13, 2024
-
Merge branch 'feat/TUP-700-core-components-node-pkg--wrappers' into f…
…eat/TUP-700-core-components-node-pkg--storybook
Configuration menu - View commit details
-
Copy full SHA for 6234e49 - Browse repository at this point
Copy the full SHA 6234e49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d84cdf - Browse repository at this point
Copy the full SHA 2d84cdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f562b89 - Browse repository at this point
Copy the full SHA f562b89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c9d2c - Browse repository at this point
Copy the full SHA 46c9d2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c445495 - Browse repository at this point
Copy the full SHA c445495View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3db236e - Browse repository at this point
Copy the full SHA 3db236eView commit details -
chore: (redundantly) include optional dependences
Optional dependencies are installed by default. We can not disable "install optional by default", cuz NX will fail: nrwl/nx#20617 We can not configure NPM to omit optional deps only per workspace, cuz: npm/cli#6099
Configuration menu - View commit details
-
Copy full SHA for 5fced48 - Browse repository at this point
Copy the full SHA 5fced48View commit details -
fix: limit install overhead for core-components
For core-components, tell dev to only install for core-components.
Configuration menu - View commit details
-
Copy full SHA for d486557 - Browse repository at this point
Copy the full SHA d486557View commit details -
fix: add missing dependencies for core-components
All this change was required to run `npx nx serve core-components`.
Configuration menu - View commit details
-
Copy full SHA for ab27f19 - Browse repository at this point
Copy the full SHA ab27f19View commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a1bcd7 - Browse repository at this point
Copy the full SHA 3a1bcd7View commit details -
Error occurred as red squiggly udnerline in code editor when importing a component from within a component.
Configuration menu - View commit details
-
Copy full SHA for 3443beb - Browse repository at this point
Copy the full SHA 3443bebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43f8c99 - Browse repository at this point
Copy the full SHA 43f8c99View commit details
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 904200a - Browse repository at this point
Copy the full SHA 904200aView commit details