feat: TUP-700 @tacc/core-components - Storybook #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STEPS 1. `npm add -D @nx/storybook@17.2.8` 2. `npx nx@17.2.8 g @nx/storybook:configuration core-components --uiFramework="@storybook/react-vite" --bundler="vite"` 3. "Do you want to set up Storybook interaction tests? (Y/n) › false" CONCERNS 1. Generator installed `@swc-node/register` and `@swc/core`. 2. `@vitejs/plugin-react-swc` is already isntalled. 3. [Storybook 7 does not work with @vitejs/plugin-react-swc](storybookjs/storybook#22381) 4. I worry I cannot move to Storybook 8 via NX, because it requires NX v18.
- Vite already uses `@vitejs/plugin-react-swc` (notice the SWC). - Storybook seems to work fine without these. - I read that in v8, Storybook will stop isntalling backup compilers.
10 tasks
…0-core-components-node-pkg--storybook
…0-core-components-node-pkg--storybook
…0-core-components-node-pkg--storybook
Running npm ci at this point: - DOES reinstall deps - does NOT create libs/core-components/node_modules - does NOT create libs/core-components/package-lock.json
wesleyboar
changed the base branch from
feat/TUP-700-core-components-node-pkg
to
feat/TUP-700-core-components-node-pkg--wrappers
…eat/TUP-700-core-components-node-pkg--storybook
…eat/TUP-700-core-components-node-pkg--storybook
…eat/TUP-700-core-components-node-pkg--storybook
…eat/TUP-700-core-components-node-pkg--storybook
…eat/TUP-700-core-components-node-pkg--storybook
…eat/TUP-700-core-components-node-pkg--storybook
This causes more work when renaming a library.
…eat/TUP-700-core-components-node-pkg--storybook
These references are outside of this lib, so yeah, reference lib name.
…eat/TUP-700-core-components-node-pkg--storybook
…eat/TUP-700-core-components-node-pkg--storybook
Optional dependencies are installed by default. We can not disable "install optional by default", cuz NX will fail: nrwl/nx#20617 We can not configure NPM to omit optional deps only per workspace, cuz: npm/cli#6099
For core-components, tell dev to only install for core-components.
All this change was required to run `npx nx serve core-components`.
Error occurred as red squiggly udnerline in code editor when importing a component from within a component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add Storybook to Core-Components.
Status
Related
Changes
./storybookconfigTesting
Setup
Important
0.
rm -rf node_modulesRun Demo
npm install --include=optional --workspace=libs/core-componentsnpx nx serve core-componentsBuild Demo
npm install --include=optional --workspace=libs/core-componentsnpx nx build-storybook core-componentsnpx serve dist/storybook/core-componentsWill probably work if "Build Lib" is fixed.
Build Lib
npm install --include=optional --workspace=libs/core-componentsnpx nx build core-componentsWorks if using
npm ci.Works on feat: TUP-700 @tacc/core-components - core-wrappers #458.
Fails if using
npm install --include=optional --workspace=libs/core-components.UI
Issues
Important
Adds optional dependencies that are installed by default (details: 5fced48).