Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cmd-84 cleanup tup-534 table css ⚠️ #302

Draft
wants to merge 44 commits into
base: feat/cmd-111-new-mobile-table-ui
Choose a base branch
from

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    2329dc9 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. adds in data attributes to each col. Isn't right just yet.

    Specifically not working for nested tables just yet. Also, need to look at paragraph tables with no headers - padding adjusts for headers even when there are none...
    R-Tomas-Gonzalez committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    976eaf9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    790f4c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Task/tup 534 auto get correct data col value (#277)

    * test: get correct data-col value (INCOMPLETE)
    
    * feat: get correct col names & values (INCOMPLETE)
    
    * feat: get correct col names & values (SUCCESS)
    
    * chore: clean up new helper getColFromRow
    
    * refactor: less chars in hbs, more logic in config
    
    * fix: remove cruft change
    
    * chore: remove console.log
    
    * fix: missing cols breaks getColFromRow
    
    * chore: simplify previous fix
    wesleyboar committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ed2863e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1218ad6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b4f953a View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    47466c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0cdebfa View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. includes all basic adjustments

    accomplishes 1 - 3 on design dev mtg notes.(will attach comments).
    R-Tomas-Gonzalez committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b440a77 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Configuration menu
    Copy the full SHA
    396b40d View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. tier one. adjusting and cleaning up all borders.

     we can adjust from here when/if needed. But for now, they are mimiced from desktop to mobile
    R-Tomas-Gonzalez committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    87ea7e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a2cf01 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. tier 3. Table cleanup after subsequent meeting with design

    Awaiting design for feedback on nested tables.
    R-Tomas-Gonzalez committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f33bcf2 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    8bdc030 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90e0273 View commit details
    Browse the repository at this point in the history
  3. updating to match more reviews

    removing commented out code in fractal. commenting out correct table truncation
    R-Tomas-Gonzalez committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e902afd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b5a5dd1 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Configuration menu
    Copy the full SHA
    d29f662 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a9b0b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5006151 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. fix: restore s-paragraph-table (removed in 0a9b0b6)

    This table is a Trump (Scope) pattern used by CMS.
    
    It is loaded by table to keep code DRY, but it should appear in Trumps section of demo.
    
    I welcome discussion of different solutions. This is not the only such case like this.
    
    P.S. The s-truncated-table was removed in 0a9b0b6 also. That's expected. No clients use it. If they want truncation, they can use Core-Styles truncation or do it themselves.
    wesleyboar committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    714c95b View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Configuration menu
    Copy the full SHA
    cdca812 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. update with main

    R-Tomas-Gonzalez committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6a8033e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4305afa View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    19149e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    985cb63 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. chore: remove outdated style

    This style is merely coloring a row to be the same as it is already.
    
    Before, it hadd a purpose, but the design has since changed.
    wesleyboar committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    8176020 View commit details
    Browse the repository at this point in the history
  2. chore: remove another outdated style

    This style matched parent row height, but that design is outdated.
    wesleyboar committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    d8a1ad6 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. feat: do not use :has(…)

    wesleyboar committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    acef9c3 View commit details
    Browse the repository at this point in the history
  2. feat: complex .has-table → simple :has(table)

    - color cell rows, not cells
    - switch from `.has-table` to `:has(table)`
    - simplify "has table" selectors
    - only color cells for `.o-fixed-header-table`
    - comment on code that may be cruft
    wesleyboar committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8700d34 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    672fe5f View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. fix: remove unused styles

    peer-programmed with T.G. to confirm
    
    Note: one style W.B. thought should go was retained because it does soemthing:
    
      table.has-table {
        & tr :is(td,th):last-child {
          border-bottom: unset;
        }
      }
    wesleyboar committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    74f6077 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2884947 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a67442c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a10fb9f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5d504b6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4229479 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c6f8af3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cea2fb8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    73c68dd View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5635e69 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    408259a View commit details
    Browse the repository at this point in the history
  2. chore: remove comment that seems outdated

    Design approved styles. I approved styles.
    wesleyboar committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3db5ddd View commit details
    Browse the repository at this point in the history
  3. feat: use custom-media

    wesleyboar committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ac113c1 View commit details
    Browse the repository at this point in the history