fix: cmd-84 cleanup tup-534 table css ⚠️ #302
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically not working for nested tables just yet. Also, need to look at paragraph tables with no headers - padding adjusts for headers even when there are none...
* test: get correct data-col value (INCOMPLETE) * feat: get correct col names & values (INCOMPLETE) * feat: get correct col names & values (SUCCESS) * chore: clean up new helper getColFromRow * refactor: less chars in hbs, more logic in config * fix: remove cruft change * chore: remove console.log * fix: missing cols breaks getColFromRow * chore: simplify previous fix
accomplishes 1 - 3 on design dev mtg notes.(will attach comments).
we can adjust from here when/if needed. But for now, they are mimiced from desktop to mobile
Awaiting design for feedback on nested tables.
removing commented out code in fractal. commenting out correct table truncation
This table is a Trump (Scope) pattern used by CMS. It is loaded by table to keep code DRY, but it should appear in Trumps section of demo. I welcome discussion of different solutions. This is not the only such case like this. P.S. The s-truncated-table was removed in 0a9b0b6 also. That's expected. No clients use it. If they want truncation, they can use Core-Styles truncation or do it themselves.
This style is merely coloring a row to be the same as it is already. Before, it hadd a purpose, but the design has since changed.
This style matched parent row height, but that design is outdated.
- color cell rows, not cells - switch from `.has-table` to `:has(table)` - simplify "has table" selectors - only color cells for `.o-fixed-header-table` - comment on code that may be cruft
peer-programmed with T.G. to confirm
Note: one style W.B. thought should go was retained because it does soemthing:
table.has-table {
& tr :is(td,th):last-child {
border-bottom: unset;
}
}
wesleyboar
added
fix
Design approved styles. I approved styles.
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the base branch from
main
to
feat/cmd-111-new-mobile-table-ui
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Caution
Do not merge
mainyet. #275 is reverted by #313. That revert will cause trouble here. Solution not certain.Overview
To restore & fix & polish #275.
Related
Changes
…
Testing
UI
…