Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up templates for TACC/Core-CMS#710 #189

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 29, 2023

Overview

Clean up templates in a way that supports https://github.com/TACC/Core-CMS-Custom and https://github.com/TACC/tup-ui overwrites of them.

Related

Changes

  • removed now-duplicate render of page title
    because TACC/Core-CMS#710 does that in base.html

Testing

  1. Deploy all sites.
  2. Verify favicon matches production.
  3. Verify page titles match production.

UI

@wesleyboar wesleyboar changed the title chore: move page_attribute "page_title" to base chore: clean up templates for TACC/Core-CMS#710 Aug 29, 2023
wesleyboar and others added 5 commits September 1, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant