chore: clean up templates for TACC/Core-CMS#710 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core-CMS will load the favicon in assets_core. Core-CMS-Custom is not supposed to overwrite assets_core. TACC/Core-CMS@4086324
wesleyboar
changed the title
This was referenced Aug 29, 2023
wesleyboar
changed the title
wesleyboar
changed the title
No reason to show the non-loading of a stylesheet. This template is not loaded, thus the stylesheet is not loaded.
Merged
Core-CMS will load the favicon in assets_core. Core-CMS-Custom is not supposed to overwrite assets_core. TACC/Core-CMS@4086324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Clean up templates with a https://github.com/TACC/Core-CMS that supports template overwrite instead of inheritance.
Related
Changes
cuz TACC/Core-CMS#710 is off of v3.12.0-beta.3
assets_customcuz it is now loaded in
assets_coredemdata_cms/…/templates/nav_search.raw.htmlcuz it is never loaded anyway (
INCLUDES_SEARCH_BAR = False)Testing
UI
…