Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize many things #1285

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions github-dark.user.css
Expand Up @@ -8783,6 +8783,18 @@
.project-card code {
background: #333 !important;
}
/* fix gh circlebadge bg e.g. https://github.com/marketplace/dependabot-preview */
.CircleBadge--github::after {
background-color: var(--color-icon-primary);
}
.CircleBadge-icon[alt*="workflow logo"] {
filter: invert(.95) brightness(1.5) grayscale(1);
mix-blend-mode: lighten;
}
/* fix GH circlebadge https://github.com/login/oauth/authorize?client_id=c602a8bd54b1e774f864&scope=repo */
.CircleBadge[style*="background-color: #fff; overflow"] {
background-color: var(--color-bg-tertiary);
}
}
@-moz-document regexp("^https?://((education|gist|graphql|guides|raw|resources|status|developer|support|vscode-auth)\\.)?github\\.com/((?!(sponsors)).)*$"), domain("githubusercontent.com"), domain("www.githubstatus.com") {
/*[[syntax-theme]]*//*[[syntax-jupyter]]*/
Expand Down
12 changes: 12 additions & 0 deletions src/main.css
Expand Up @@ -2299,4 +2299,16 @@
.project-card code {
background: #333 !important;
}
/* fix gh circlebadge bg e.g. https://github.com/marketplace/dependabot-preview */
.CircleBadge--github::after {
background-color: var(--color-icon-primary);
}
.CircleBadge-icon[alt*="workflow logo"] {
filter: invert(.95) brightness(1.5) grayscale(1);
mix-blend-mode: lighten;
}
/* fix GH circlebadge https://github.com/login/oauth/authorize?client_id=c602a8bd54b1e774f864&scope=repo */
.CircleBadge[style*="background-color: #fff; overflow"] {
background-color: var(--color-bg-tertiary);
}
Comment on lines +2302 to +2313
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @the-j0k3r.
I copied and pasted your code, is that okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its fine, however check that it fixes the examples given with GHD.

Also those css vars need to be assigned values overriding the existing, these CSS vars need to be added to vars.css

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What color do you prefer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What color do you prefer?

I dont prefer any color, I would perhaps use already defined colors based on GHD palette, something that works when user selects other colors other than what --ghd-bg-color gives you, ya good luck, this style is insane since it doesnt add all available CSS vars and overrides them, so the colors will never fit in

}