Colorize many things #1285

koumaza · 2020-12-24T20:57:54Z

Probably, Squash and Commit required.

UserCss:
https://github.com/koumaza/GitHub-Dark/blob/koumaza/suggestion/github-dark.user.css?raw=true

Screenshots

Close button
Dropdown Caret
Kebab Icon
Markdown Anchor
- When :active
Organizations Border
Acv Underline
- When :hover
"Remove Public Email" Colorize in Settings/Profile

add header link state override Co-authored-by: the-j0k3r <31389848+the-j0k3r@users.noreply.github.com>

silverwind · 2020-12-24T23:43:19Z

Hmm not sure on this one. We generally follow the rule that if something is not colored in the original themes, we don't add color. Of course there are exceptions like the navbar hover, but generally I think we should not stray too far from the original style.

Another issue is all these "manual" rules will sooner or later become outdated because GitHub often rapidly changes things, so they will eventually become a maintenance burden.

koumaza · 2020-12-25T03:20:43Z

Hi @silverwind
I understood.
But, Kebab Icon and Markdown Anchor are colorize comes from the original style.
I'll make change just for them.

Another issue is all these "manual" rules will sooner or later become outdated because GitHub often rapidly changes things, so they will eventually become a maintenance burden

This is the fate of UserCss.

the-j0k3r · 2020-12-25T08:00:10Z

Again, replace CSS vars colors instead of adding more selectors, what youre doing is only OK if for instance GH isnt using css vars in that particular area.

This style already has many many opinionated tweaks to colors in these octicon-x areas so these fit right in, however adding more selectors is not the way, replacing CSS vars colors is the only way to get sane styles.

koumaza · 2020-12-25T08:31:49Z

OK, I'll add to vars.css

src/main.css

* Grant Style to "Trending" Tab (StylishThemes#1284) add header link state override Co-authored-by: the-j0k3r <31389848+the-j0k3r@users.noreply.github.com> * add underline nav vars * v4.2.131 * add underline nav vars (silverwind) * Grant Style to "Trending" Tab (StylishThemes#1284) (shanghai yakisoba chan!) * fix excessive vertical padding on code suggestions * update deps * v4.2.132 * update deps (silverwind) * fix excessive vertical padding on code suggestions (silverwind) * automated regeneration * v4.2.133 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.134 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.135 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.136 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.137 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.138 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.139 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.140 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.141 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.142 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.143 * automated regeneration (github-actions[bot]) * automated regeneration * v4.2.144 * automated regeneration (github-actions[bot]) Co-authored-by: the-j0k3r <31389848+the-j0k3r@users.noreply.github.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

koumaza · 2021-01-14T14:46:38Z

src/main.css

+  /* fix gh circlebadge bg e.g. https://github.com/marketplace/dependabot-preview */
+  .CircleBadge--github::after {
+    background-color: var(--color-icon-primary);
+  }
+  .CircleBadge-icon[alt*="workflow logo"] {
+    filter: invert(.95) brightness(1.5) grayscale(1);
+    mix-blend-mode: lighten;
+  }
+  /* fix GH circlebadge https://github.com/login/oauth/authorize?client_id=c602a8bd54b1e774f864&scope=repo */
+  .CircleBadge[style*="background-color: #fff; overflow"] {
+    background-color: var(--color-bg-tertiary);
+  }


Hi @the-j0k3r.
I copied and pasted your code, is that okay?

Its fine, however check that it fixes the examples given with GHD.

Also those css vars need to be assigned values overriding the existing, these CSS vars need to be added to vars.css

What color do you prefer?

What color do you prefer?

I dont prefer any color, I would perhaps use already defined colors based on GHD palette, something that works when user selects other colors other than what --ghd-bg-color gives you, ya good luck, this style is insane since it doesnt add all available CSS vars and overrides them, so the colors will never fit in

the-j0k3r · 2021-01-14T16:13:05Z

github-custom-fonts.user.css

@@ -1,7 +1,7 @@
 /* ==UserStyle==
 @name         GitHub Custom Fonts
 @namespace    StylishThemes
-@version      4.2.130
+@version      4.2.144


dont bump versions pls

This will cause conflicts at merge.

This Bumpup was when rebased from Master.
I think to merge Master and version together.
It is okay?

IDK how you rebased, but a proper rebase wouldn't introduce changes that you haven't added manually.

lets assume you setup an upstream (named) remote when you forked this repo. if not replace upstream with the name or your remote.

run git pull --rebase upstream master then followed by git push --force

That should be round about it. assuming that you deleted this rebase commit =)

the-j0k3r · 2021-01-14T16:13:22Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "GitHub-Dark",
-  "version": "4.2.130",
+  "version": "4.2.144",


no bumping versions pls

Grant Style to "Trending" Tab (StylishThemes#1284)

9b388ae

add header link state override Co-authored-by: the-j0k3r <31389848+the-j0k3r@users.noreply.github.com>

koumaza changed the title ~~Grant Style to "Trending" Tab (#1284)~~ Colorize many things Dec 24, 2020

the-j0k3r reviewed Jan 10, 2021

View reviewed changes

src/main.css Outdated Show resolved Hide resolved

koumaza and others added 3 commits January 14, 2021 23:01

Colorize UnderLineNav Text when hover

1190f68

Colorize GH Circlebadge

d351b89

koumaza force-pushed the koumaza/suggestion branch from 127b0b2 to d351b89 Compare January 14, 2021 14:27

koumaza commented Jan 14, 2021

View reviewed changes

the-j0k3r requested changes Jan 14, 2021

View reviewed changes

koumaza force-pushed the koumaza/suggestion branch from c8d413d to d351b89 Compare February 12, 2021 05:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Colorize many things #1285

Colorize many things #1285

koumaza commented Dec 24, 2020

silverwind commented Dec 24, 2020 •

edited

koumaza commented Dec 25, 2020 •

edited

the-j0k3r commented Dec 25, 2020 •

edited

koumaza commented Dec 25, 2020

koumaza Jan 14, 2021

the-j0k3r Jan 14, 2021

koumaza Jan 15, 2021

the-j0k3r Jan 15, 2021

the-j0k3r Jan 14, 2021

the-j0k3r Feb 11, 2021

koumaza Feb 12, 2021 •

edited

the-j0k3r Feb 12, 2021 •

edited

the-j0k3r Jan 14, 2021

Colorize many things #1285

Are you sure you want to change the base?

Colorize many things #1285

Conversation

koumaza commented Dec 24, 2020

silverwind commented Dec 24, 2020 • edited

koumaza commented Dec 25, 2020 • edited

the-j0k3r commented Dec 25, 2020 • edited

koumaza commented Dec 25, 2020

koumaza Jan 14, 2021

Choose a reason for hiding this comment

the-j0k3r Jan 14, 2021

Choose a reason for hiding this comment

koumaza Jan 15, 2021

Choose a reason for hiding this comment

the-j0k3r Jan 15, 2021

Choose a reason for hiding this comment

the-j0k3r Jan 14, 2021

Choose a reason for hiding this comment

the-j0k3r Feb 11, 2021

Choose a reason for hiding this comment

koumaza Feb 12, 2021 • edited

Choose a reason for hiding this comment

the-j0k3r Feb 12, 2021 • edited

Choose a reason for hiding this comment

the-j0k3r Jan 14, 2021

Choose a reason for hiding this comment

silverwind commented Dec 24, 2020 •

edited

koumaza commented Dec 25, 2020 •

edited

the-j0k3r commented Dec 25, 2020 •

edited

koumaza Feb 12, 2021 •

edited

the-j0k3r Feb 12, 2021 •

edited