Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Krylov tutorial #1332

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Refactor Krylov tutorial #1332

wants to merge 10 commits into from

Conversation

frankharkins
Copy link
Member

This tutorial was originally created in IBM-Quantum-Technical-Enablement/quantum-enablement#11. Part of #1166.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ abbycross
✅ frankharkins
❌ miamico
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Eric-Arellano
Copy link
Collaborator

Maybe we need a blocklist mechanism for notebooks that completely fail? It'd be best to not try to fix the notebook in this PR, but we also don't want CI to be red.

@frankharkins
Copy link
Member Author

I think @abbycross will be working on this branch, so we can fix it in this PR

@abbycross abbycross changed the title Migrate Krylov tutorial Refactor Krylov tutorial May 14, 2024
@abbycross
Copy link
Collaborator

Hi @miamico! I've gone through to do voice/style edits on this tutorial, and am trying to run the notebook. The code throws an error in Step 3 - can you see what's going on?

@Eric-Arellano
Copy link
Collaborator

Hi @miamico! I've gone through to do voice/style edits on this tutorial, and am trying to run the notebook. The code throws an error in Step 3 - can you see what's going on?

Is it that the notebook is using 11 qubits? We're trying to run this notebook with our 5-qubit simulator in CI, but if it requires 11 qubits, that won't work. If this notebook can't be rewritten to work with the 5-qubit simulator, then we need to update notebooks.toml to move it from notebooks_that_submit_jobs to instead notebooks_no_mock. It's desirable to allow us to mock it if possible so that we get more CI validation.

@miamico
Copy link
Collaborator

miamico commented May 16, 2024

I'm working on a version of this notebook that will be using the hardware at utility scale. I'd hold off any further work on this version based on the simulator

@abbycross
Copy link
Collaborator

I'm working on a version of this notebook that will be using the hardware at utility scale. I'd hold off any further work on this version based on the simulator

@miamico ok thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants