Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh outputs in all notebooks #1226

Closed
wants to merge 12 commits into from
Closed

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Apr 24, 2024

I ran the notebook testing script yesterday to test it was submitting jobs correctly, and noticed the jobs were being executed immediately. I decided to take advantage of this and leave the script running. These are the notebooks with the refreshed outputs.

Two notebooks did not execute correctly:

And tutorials/variational-quantum-eigensolver/vqe.ipynb had not completed when I cancelled the script this morning (#1229).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@frankharkins
Copy link
Member Author

frankharkins commented Apr 24, 2024

CI is failing due to a requests error, this should be temporary and fixed soon.

RequestsApiError: "HTTPSConnectionPool(host='auth.quantum-computing.ibm.com', port=443): Max retries exceeded with url: /api/version (Caused by ResponseError('too many 503 error responses'))"

EDIT: That problem is now fixed, but we have another (https://github.com/orgs/community/discussions/120966). See #1230 for a temporary solution.

@qiskit-bot
Copy link
Contributor

One or more of the the following people are requested to review this:

@frankharkins
Copy link
Member Author

This is ready to review. CI is now failing due to the matplotlib warnings, but these should be fixed as part of #1184.

⚠️ Warnings in docs/transpile/custom-transpiler-pass.ipynb:
Cell 7:
 │ Matplotlib is building the font cache; this may take a moment.

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I opened #1239 so that we don't need this as often in the future.

Before merging, please double check if the learning platform supports SVGs. Or merge this and confirm it works in staging, but be ready to revert the tutorials/ changes quickly need be.

@frankharkins
Copy link
Member Author

CI is also failing because the repetition codes notebook uses qiskit-ibm-provider, which doesn't work with our testing patch. I think it's ok to merge as the failure is not due to this PR and the notebook should be migrated to qiskit-ibm-runtime as part of #1137.

❌ Problem in tutorials/build-repetition-codes/build-repetition-codes.ipynb:
A cell timed out while it was being executed, after 300 seconds.
The message was: Cell execution timed out.
Here is a preview of the cell contents:
-------------------
job_no_correction = backend.run(transpiled_no_correction_circuit, shots=1000, dynamic=True)
result_no_correction = job_no_correction.result()
-------------------

Checking for trailing jobs...
⚠️ Cancelling 1 job(s) created after 2024-05-09 12:31:15.823406.

@Eric-Arellano
Copy link
Collaborator

Instead, I recommend we do the blocklist mechanism: #1332 (comment). We should avoid ever merging broken CI.

This reverts commit 962bb52.

I get the two notebooks confused all the time.
@frankharkins
Copy link
Member Author

Closing in favour of PRs with newer outputs

@frankharkins frankharkins deleted the FH/refresh-outputs branch May 16, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants