Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/throttle override not published #319

Open
wants to merge 23 commits into
base: maint/throttle-override
Choose a base branch
from

Commits on Jun 27, 2018

  1. Add signed value to brake request

    Prior to this commit the brake request was set to unsigned float which does not
    exist. This commit fixes that by changing the value to a signed float.
    rebpdx committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    4aad545 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #296 from PolySync/fix/dbc-not-signed

    Add signed value to brake request
    shnewto committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    fb13172 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. Build in docker

    Russell Mull authored and Russell Mull committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    cf05d79 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. Remove D-CAN filters

    Boris Bidault committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    9f5a978 View commit details
    Browse the repository at this point in the history
  2. Add Soul EV throttle CAN-ID

    Boris Bidault committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    ca8bca0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #301 from PolySync/remove-dcan-filters

    Remove dcan filters
    cotos committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    04b208b View commit details
    Browse the repository at this point in the history
  4. Increase required steering torque to override

    Prior to this commit custom applications that required rapid and changes to the steering wheel position were able to programatically apply enough torque to artificially trigger operator override. This resulted in applications where the steering module disabled in unintended ways. This commit addresses that by increasing the torque required to trigger operator override without significantly impeding the a safety driver's ability to trigger override by manually turning the steering wheel. After this commit applications that require rapid changes to steering angle position should not result in any unintended disabling of the steering module.
    Shea Newton committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    c8c742d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. Add docker.build call

    Prior to this commit the parallel builds did not have a docker.build command
    causing multiple workers to be missing a docker container to work in. This
    commit fixes that by adding the build command to ensure that each worker node
    has a container to use.
    rebpdx committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    eb6b8d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Add Niro throttle CAN-ID

    Boris Bidault committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    67e96b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. Merge pull request #303 from PolySync/add-niro-throttle-can-id

    Add Niro throttle CAN-ID
    cotos committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    7552015 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Merge pull request #305 from PolySync/maint/increase-steering-overrid…

    …e-torque
    
    Increase required steering torque to override
    cotos committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    5bd83a3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #300 from PolySync/docker-based-build

    Build in docker
    shnewto committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    07d0787 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2018

  1. Clean working directory

    Prior to this commit failed builds would leave a dirty working directory. This
    commit fixes that by adding a try, finally block to make sure the directory is
    cleaned.
    rebpdx committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    3e05c6a View commit details
    Browse the repository at this point in the history
  2. Move checkout inside try block

    Prior to this commit the checkout call was outside the try block. This commit
    fixes that by moving the checkout into the try block incase it fails and the
    working directory still needs to be cleaned up.
    rebpdx committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    b3bbab8 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #306 from PolySync/maint/clean-workspace

    Clean working directory
    Boris Bidault committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    9e740a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Add EV & Niro vehicle speed can ids

    Boris Bidault committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    2f1dc29 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #309 from PolySync/add-vehicle-speed-can-ids

    Add EV & Niro vehicle speed can ids
    shnewto committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    f7cef6d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Configuration menu
    Copy the full SHA
    8ba2872 View commit details
    Browse the repository at this point in the history
  2. Fix jenkins workspace cleanup

    Prior to this commit some builds would fail trying to clean up the workspace
    directory. This commit fixes that by removing the inner cleanup since the try
    block for the parallel builds should catch any errors from workspace builds.
    rebpdx committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    0a60389 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #311 from PolySync/bug/fix-jenkins-cleanup

    Fix jenkins workspace cleanup
    cotos committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    bfa3f4a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. correct comment

    Boris Bidault committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    fcfe5f7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #310 from PolySync/fix/decrease-brake-pedal-overri…

    …de-threshold
    
    reduce BREAK_PEDAL_OVERRIDE_THRESHOLD
    cotos committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    8a163e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. Throttle operator override not being published

    Prior to thie commit the signal, "throttle_operator_override" in the message, "THROTTLE_REPORT(0x93)" did not report a status of driver's throttle override, whereas, the signal, "throttle_report_enabled" in the same message reports properly. The override report signals of steering/brake works well.
    
    The operator override was being generated but not published.
    
    Fix:
    Used operator override logic the brake is using.
    
    Verification:
    Ran `https://github.com/PolySync/oscc-check/blob/master/oscc-check.py` to enable all modules.  Performed a throttle operator override.
    
    Verified throttle operator overide
    
    ```
    $ candump can0,093:7FF
      can0  093   [8]  05 CC 01 00 00 B5 08 B8
      can0  093   [8]  05 CC 01 00 00 B5 08 B8
      can0  093   [8]  05 CC 01 00 00 5F 02 1F
      can0  093   [8]  05 CC 00 01 02 B5 08 B8
      can0  093   [8]  05 CC 00 01 02 B5 08 B8
      can0  093   [8]  05 CC 00 01 02 B5 08 B8
    ```
    cotos committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    e82ac40 View commit details
    Browse the repository at this point in the history