Fix/throttle override not published #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the brake request was set to unsigned float which does not exist. This commit fixes that by changing the value to a signed float.
Add signed value to brake request
Remove dcan filters
Prior to this commit custom applications that required rapid and changes to the steering wheel position were able to programatically apply enough torque to artificially trigger operator override. This resulted in applications where the steering module disabled in unintended ways. This commit addresses that by increasing the torque required to trigger operator override without significantly impeding the a safety driver's ability to trigger override by manually turning the steering wheel. After this commit applications that require rapid changes to steering angle position should not result in any unintended disabling of the steering module.
Prior to this commit the parallel builds did not have a docker.build command causing multiple workers to be missing a docker container to work in. This commit fixes that by adding the build command to ensure that each worker node has a container to use.
Add Niro throttle CAN-ID
…e-torque Increase required steering torque to override
Build in docker
Prior to this commit failed builds would leave a dirty working directory. This commit fixes that by adding a try, finally block to make sure the directory is cleaned.
Prior to this commit the checkout call was outside the try block. This commit fixes that by moving the checkout into the try block incase it fails and the working directory still needs to be cleaned up.
Clean working directory
Add EV & Niro vehicle speed can ids
Prior to this commit some builds would fail trying to clean up the workspace directory. This commit fixes that by removing the inner cleanup since the try block for the parallel builds should catch any errors from workspace builds.
Fix jenkins workspace cleanup
…de-threshold reduce BREAK_PEDAL_OVERRIDE_THRESHOLD
Prior to thie commit the signal, "throttle_operator_override" in the message, "THROTTLE_REPORT(0x93)" did not report a status of driver's throttle override, whereas, the signal, "throttle_report_enabled" in the same message reports properly. The override report signals of steering/brake works well. The operator override was being generated but not published. Fix: Used operator override logic the brake is using. Verification: Ran `https://github.com/PolySync/oscc-check/blob/master/oscc-check.py` to enable all modules. Performed a throttle operator override. Verified throttle operator overide ``` $ candump can0,093:7FF can0 093 [8] 05 CC 01 00 00 B5 08 B8 can0 093 [8] 05 CC 01 00 00 B5 08 B8 can0 093 [8] 05 CC 01 00 00 5F 02 1F can0 093 [8] 05 CC 00 01 02 B5 08 B8 can0 093 [8] 05 CC 00 01 02 B5 08 B8 can0 093 [8] 05 CC 00 01 02 B5 08 B8 ```
ghost
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a branch to send throttle override fix to Sungwoo Mobile