New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining todos #4022
Merged
Merged
Remaining todos #4022
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8151505
remove unnecessary TODO which is a left over
danielmarbach 7edc391
Remove left over TODO in CachingHttpHandler (we remove the other ones…
danielmarbach ba4cd06
Align the monitor http logging with the other instances
danielmarbach 6aca336
Previously we used AllowAnyHeader = false and AllowAnyHeader = false.…
danielmarbach d7af936
We know SP isn't using SignalR at all, and that will have to be adde…
danielmarbach bf1c3e4
Address TODO in GetRetryPendingMessages for now but we probably shoul…
danielmarbach File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauroservienti you have a bit more knowledge about RavenDB. This whole thing is weird. We basically pulled down the entire FailedMessage to then just use the UniqueMessageId. Then we bring that up to the outer layers which then iterates through those, creates FailedMessageRetry Ids to then delete them 1:1. Horrible. I tried to do a DeleteByQuery but that doesn't work to my knowledge since the collection I query from and have to delete from are different. So I tried to at least materialize less from the server.
As a next small improvement, we could change the
RemoveFailedMessageRetryDocument
accept a number of IDs. I was thinking a bit about streaming IDs back and then the outer layers doing batch deletes per stream, but I wasn't sure of the implications of that whole change, since we would keep the cursor open while we are trying to delete batch deletes.This TODO is a bit of a rabbit hole and not even from us 👯♂️