Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining todos #4022

Merged
merged 6 commits into from Mar 22, 2024
Merged

Remaining todos #4022

merged 6 commits into from Mar 22, 2024

Commits on Mar 20, 2024

  1. remove unnecessary TODO which is a left over

    @danielmarbach
    danielmarbach committed Mar 20, 2024
    Copy the full SHA
    8151505 View commit details
    Browse the repository at this point in the history

  2. Remove left over TODO in CachingHttpHandler (we remove the other ones… 

    … too)
    @danielmarbach
    danielmarbach committed Mar 20, 2024
    Copy the full SHA
    7edc391 View commit details
    Browse the repository at this point in the history

  3. Align the monitor http logging with the other instances

    @danielmarbach
    danielmarbach committed Mar 20, 2024
    Copy the full SHA
    ba4cd06 View commit details
    Browse the repository at this point in the history

  4. Previously we used AllowAnyHeader = false and AllowAnyHeader = false.… 

    … We are explicitely adding headers and methods that we allow.
    @danielmarbach
    danielmarbach committed Mar 20, 2024
    Copy the full SHA
    6aca336 View commit details
    Browse the repository at this point in the history

  5. We know SP isn't using SignalR at all, and that will have to be adde… 

    …d back in as a new feature later
    @danielmarbach
    danielmarbach committed Mar 20, 2024
    Copy the full SHA
    d7af936 View commit details
    Browse the repository at this point in the history

  6. Address TODO in GetRetryPendingMessages for now but we probably shoul… 

    …d also change the RemoveFailedMessageRetryDocument to be batch oriented
    @danielmarbach
    danielmarbach committed Mar 20, 2024
    Copy the full SHA
    bf1c3e4 View commit details
    Browse the repository at this point in the history