Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More small todos #4013

Merged
merged 11 commits into from Mar 18, 2024
Merged

More small todos #4013

merged 11 commits into from Mar 18, 2024

Commits on Mar 15, 2024

  1. It should be fine to return more headers

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    6672cff View commit details
    Browse the repository at this point in the history

  2. Remove cancellation token TODO

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    54321ce View commit details
    Browse the repository at this point in the history

  3. Remove workaround that is no longer needed with NSB v9

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    fd862a7 View commit details
    Browse the repository at this point in the history

  4. Get rid of weird abstraction that adds no value

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    d53b870 View commit details
    Browse the repository at this point in the history

  5. Readonly

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    caeed12 View commit details
    Browse the repository at this point in the history

  6. For now add a comment until we know more from RavenDB.

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    28aae3f View commit details
    Browse the repository at this point in the history

  7. It should be fine to return more headers

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    cc268c9 View commit details
    Browse the repository at this point in the history

  8. This problem existed before and we didn't really make it worse. Movin… 

    …g on
    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    310cb26 View commit details
    Browse the repository at this point in the history

  9. Switch to content result and explicit header and status for now (SP a… 

    …djusted)
    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    5d8d0cf View commit details
    Browse the repository at this point in the history

  10. Connection Details parsing is case insensitive with PropertyNameCaseI… 

    …nsensitive = true in the platform connector package
    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    ec0b8e5 View commit details
    Browse the repository at this point in the history

  11. Honestly our caching approach probably requires an overhaul anyway

    @danielmarbach
    danielmarbach committed Mar 15, 2024
    Copy the full SHA
    5acfcc7 View commit details
    Browse the repository at this point in the history