Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More small todos #4013

Merged
merged 11 commits into from Mar 18, 2024
Merged

More small todos #4013

merged 11 commits into from Mar 18, 2024

Conversation

danielmarbach
Copy link
Contributor

No description provided.

@@ -20,5 +20,5 @@
"CustomChecksQueue": "Particular.ServiceControl"
}
},
"errors": []
"Errors": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these changes breaking the PlatformConnection plugin? (I have not checked it myself, yet)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the commit message ;)

Connection Details parsing is case insensitive with PropertyNameCaseInsensitive = true in the platform connector package

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I missed that.

@mauroservienti mauroservienti merged commit d854f29 into master Mar 18, 2024
19 checks passed
@mauroservienti mauroservienti deleted the more-small-todos branch March 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants