Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal supported Windows version to Windows Vista (0x0600). #499

Open
wants to merge 4 commits into
base: Cog
Choose a base branch
from

Commits on May 12, 2020

  1. Bump minimal supported Windows version to Windows 8 (0x0602).

    Also fixes a minor issue in MSVC Makefile for 64x64, which tried 0x0801 for Windows 8 and 0x1001 for Windows 10. The latter would actually be 0x0A00. See https://docs.microsoft.com/de-de/cpp/porting/modifying-winver-and-win32-winnt
    
    Also in the Makefile for 64x64, define both _WIN32 and _WIN64. See https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
    
    Also in the Makefile for 64x64, define both WIN32 and WIN64 because those can be used to identify the Windows platform in application code such as in processors/IA32/bochs. I am not aware of any #ifdef WIN64 at the moment. Most code uses #ifdef _WIN64 to check for that.
    
    Note that, having defined both _WIN32 and _WIN64, code for 32-bit and 64-bit must always begin with #ifdef _WIN64 and only then #ifdef _WIN32.
    
    I think that the MSVC compiler defines _WIN32 and _WIN64 automatically. Yet, now it is documented in the Makefile.
    marceltaeumel committed May 12, 2020
    Configuration menu
    Copy the full SHA
    fbedb8e View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Configuration menu
    Copy the full SHA
    eae037b View commit details
    Browse the repository at this point in the history
  2. Revert alloca to malloc

    marceltaeumel committed May 14, 2020
    Configuration menu
    Copy the full SHA
    14e3dd2 View commit details
    Browse the repository at this point in the history
  3. Bump min. supported version to Windows Vista (0x0600) instead of Wind…

    …ows 8 (0x0602), following the suggestion on the vm-dev mailing list.
    marceltaeumel committed May 14, 2020
    Configuration menu
    Copy the full SHA
    7c8bea5 View commit details
    Browse the repository at this point in the history