Bump minimal supported Windows version to Windows Vista (0x0600). #499
Conversation
Also fixes a minor issue in MSVC Makefile for 64x64, which tried 0x0801 for Windows 8 and 0x1001 for Windows 10. The latter would actually be 0x0A00. See https://docs.microsoft.com/de-de/cpp/porting/modifying-winver-and-win32-winnt Also in the Makefile for 64x64, define both _WIN32 and _WIN64. See https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros Also in the Makefile for 64x64, define both WIN32 and WIN64 because those can be used to identify the Windows platform in application code such as in processors/IA32/bochs. I am not aware of any #ifdef WIN64 at the moment. Most code uses #ifdef _WIN64 to check for that. Note that, having defined both _WIN32 and _WIN64, code for 32-bit and 64-bit must always begin with #ifdef _WIN64 and only then #ifdef _WIN32. I think that the MSVC compiler defines _WIN32 and _WIN64 automatically. Yet, now it is documented in the Makefile.
|
That error on TravisCI is misleading. All builds pass. |
| # Set minimum version to WindowsXP (see /cygwin/usr/include/w32api/w32api.h) | ||
| WINVER:=-D_WIN32_WINNT=0x0501 -DWINVER=0x0501 | ||
| # Set minimum version to Windows 8 (see /cygwin/usr/include/w32api/w32api.h) | ||
| WINVER:=-D_WIN32_WINNT=0x0602 -DWINVER=0x0602 |
There was a problem hiding this comment.
As suggested on the mailing list, I would just use 0x0600
See also https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=vs-2019 for the list of _WIN32_WINNT version.
There was a problem hiding this comment.
How would you feel about setting minimum supported version to 8.0? I want to do this because of the GetSystemTimePreciseAsFileTime function, which appears in 8.0 nd neatly solves the time issues in the win32 VM (use of the millisecond clock to derive greater precision than the 15ms tick in GetSystemTimeAsFileTime causes significant direct over the course of several days).
There was a problem hiding this comment.
We can have 0x6000 (Vista) and use that function. Ping me in a week or so, when I'm back from vacation
platforms/win32/vm/sqWin32Main.c
Outdated
| if (nameinfo == NULL) { | ||
| return -1; | ||
| } | ||
| nameinfo = alloca(size); |
There was a problem hiding this comment.
Why not, alloca is a bit shorter, but the pairs of malloc and free seems correct here...
I'd rather consider this change as un-necessary.
…ows 8 (0x0602), following the suggestion on the vm-dev mailing list.
marceltaeumel
changed the title
|
wanna merge? care to first update |
…ver with false ] on method [ setIsRememberedOf:to: ]
…er with false ] on method [ setIsRememberedOf:to: ] KILLED by 12/24 test cases.
…ItselfClassIndexPun ] 9 test cases.
…tselfClassIndexPun ] 9/9 Test Cases are NOT EQUIVALENT
Become should not forget to remember
Also fixes a minor issue in MSVC Makefile for 64x64, which tried 0x0801 for Windows 8 and 0x1001 for Windows 10. The latter would actually be 0x0A00. See https://docs.microsoft.com/de-de/cpp/porting/modifying-winver-and-win32-winnt
Also in the Makefile for 64x64, define both _WIN32 and _WIN64. See https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
Also in the Makefile for 64x64, define both WIN32 and WIN64 because those can be used to identify the Windows platform in application code such as in processors/IA32/bochs. I am not aware of any #ifdef WIN64 at the moment. Most code uses #ifdef _WIN64 to check for that.
Note that, having defined both _WIN32 and _WIN64, code for 32-bit and 64-bit must always begin with #ifdef _WIN64 and only then #elif _WIN32.
I think that the MSVC compiler defines _WIN32 and _WIN64 automatically. Yet, now it is documented in the Makefile.