Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some necessary functions & fix for AttackOverlay #21411

Merged
merged 5 commits into from Apr 30, 2024
Merged

Some necessary functions & fix for AttackOverlay #21411

merged 5 commits into from Apr 30, 2024

Conversation

dnqbob
Copy link
Contributor

@dnqbob dnqbob commented Apr 27, 2024

showcase-2

@dnqbob dnqbob changed the title Some necessary functions for AttackOverlay Some necessary functions & fix for AttackOverlay Apr 27, 2024
PunkPun
PunkPun previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, untested

Could a testcase of sorts be added?

@dnqbob
Copy link
Contributor Author

dnqbob commented Apr 30, 2024

Sure, wait for me

@dnqbob
Copy link
Contributor Author

dnqbob commented Apr 30, 2024

testcase
I pushed a code simlifying and a test case here.

@dnqbob
Copy link
Contributor Author

dnqbob commented Apr 30, 2024 •
edited

The code simplify itself proves
WithAttackOverlay: fix ZOffset not related to actor.
WithAttackOverlay: now support facing correctly with BodyOrientation
works as promise.

While test case proves
WithAttackOverlay: support decoration animation.
works as promise.

As for
WithAttackOverlay: support specifc Armament to play animation.
You can change the Armament name to see if it can trigger on different names.

@PunkPun PunkPun merged commit c63be29 into OpenRA:bleed Apr 30, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Apr 30, 2024

changelog

@dnqbob dnqbob deleted the attackoverlay branch May 1, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnqbob @PunkPun