Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deleting derivatives with zero pressure difference #877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hnil
Copy link
Member

@hnil hnil commented Feb 29, 2024

  • avoid getting zero in matrix in zero pressure/zero flux case
  • may make it easier to have lower/upper limits on pressures

This should be the correct, but it will may change many tests so it should be investigated carefully.

@GitPaean
Copy link
Member

jenkins build this opm-simulators=5236 please

@GitPaean
Copy link
Member

Somehow, it affects a lot of cases, maybe most of the regression tests. The results does not look problematic, while some checking need to be done.

https://ci.opm-project.org/job/opm-models-PR-builder/482/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants