Avoid deleting derivative i.e. getting "wrong" matrix in case of zero… #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattms
reviewed
Mar 4, 2024
Comment on lines
-281
to
-284
| if (pressureDifferences[phaseIdx] == 0) { | ||
| volumeFlux[phaseIdx] = 0.0; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I don't really understand why this changes anything. Souldn't volumeFlux[phaseindex] still be zero as there is a multiplication with zero below. What am I missing?
There was a problem hiding this comment.
It may have nonzero derivatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the correct, but it will may change many tests so it should be investigated carefully. This is same change as in model (OPM/opm-models#877) but will only affect legacy assembly.