add parameter to set maximum water saturation. Default is 1.0 #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
jenkins build this please |
totto82
force-pushed
the
maximum_water_sat
branch
from
b86c865
to
75eaee3
Compare
|
jenkins build this please |
atgeirr
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
I think this is acceptable. I would be very nervous about a future PR changing the default, especially for MaxWaterSaturation! However, I acknowledge that this makes it much easier to test various combinations and in turn perhaps find a better solution.
@hnil What do you think?
| // special case cells with almost only water | ||
| // use both saturations (if the phase is enabled) | ||
| // special case for cells with almost only water | ||
| //thresholdWaterFilledCell = std::min(thresholdWaterFilledCell, 1.0 - eps); |
totto82
force-pushed
the
maximum_water_sat
branch
from
75eaee3
to
db94249
Compare
|
jenkins build this please |
|
Thanks for approving. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of
#803
which adds a option to set the maximum water saturation. For some cases using a value slightly above 1.0 (for instance 1.05) improves the convergence significantly. Default is 1.0 so this PR should not change default results.