Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix almost filled with water to 1.0-1e-6 #817

Closed
wants to merge 1 commit into from

Conversation

totto82
Copy link
Member

@totto82 totto82 commented Aug 7, 2023

This is the third part of #803

@totto82
Copy link
Member Author

totto82 commented Aug 7, 2023

jenkins build this please

@hnil
Copy link
Member

hnil commented Aug 8, 2023

Probably put it in the tag system to be changed. Maybe we should add a type DefaultTolerances where one could get forexample (if it do not exist):

using NumTol = GetPropertyType<TypeTag, DefaultTolerances>;
static constexpr myeps = NumTol::eps;

Reasons:

  • be able to change them
  • avoid putting it as hidden defaut input
  • collect numbers used for numerical hacks ++ one place
  • avoid all the boiler plate assosiated with input parameter i.e. tag definitions, init, register.

@totto82
Copy link
Member Author

totto82 commented Aug 8, 2023

benchmark please

@totto82
Copy link
Member Author

totto82 commented Aug 8, 2023

Probably put it in the tag system to be changed.

Good point. Especially since it seem to affect lot of cases.

@totto82
Copy link
Member Author

totto82 commented Aug 14, 2023

benchmark please

@totto82
Copy link
Member Author

totto82 commented Aug 16, 2023

Added it to as a parameter here. #816

Will close this for now.

@totto82 totto82 closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants