[fix] Use minimum positive value of competing max initial time steps. #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if both TUNING and NEXTSTEP are used. In this case the smaller positive value should be used.
|
jenkins build this please |
bska
reviewed
Mar 19, 2024
Comment on lines
+401
to
+412
| /*** TIMESTEP 11 ***/ | ||
| { | ||
| std::size_t timestep = 11; | ||
| BOOST_CHECK_CLOSE(schedule[timestep].max_next_tstep(true), 1.0 * Metric::Time, diff); | ||
| BOOST_CHECK_CLOSE(schedule[timestep].max_next_tstep(false), 1.0 * Metric::Time, diff); | ||
| } | ||
| /*** TIMESTEP 12 ***/ | ||
| { | ||
| std::size_t timestep = 12; | ||
| BOOST_CHECK_CLOSE(schedule[timestep].max_next_tstep(true), 1.0 * Metric::Time, diff); | ||
| BOOST_CHECK_CLOSE(schedule[timestep].max_next_tstep(false), 2.0 * Metric::Time, diff); | ||
| } |
There was a problem hiding this comment.
Very good. Do you think you could add a test for the max_next_tstep() < 0 case as well–i.e., for when there is no NEXTSTEP and we do not enable TUNING?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if both TUNING and NEXTSTEP are used. In this case the smaller positive value should be used.