Facilitate using NEXTSTEP without --enable-tuning #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this opm-simulators=5215 please |
1 similar comment
|
jenkins build this opm-simulators=5215 please |
|
@vkip I think the changed files might have been moved. Please rebase this PR onto current master to remove the conflicts. |
vkip
force-pushed
the
nextstep_without_tuning
branch
from
d46a237
to
1f3895a
Compare
|
jenkins build this opm-simulators=5215 please |
blattms
reviewed
Feb 27, 2024
| double ScheduleState::max_next_tstep() const { | ||
| double tuning_value = this->m_tuning.TSINIT.has_value() ? this->m_tuning.TSINIT.value() : -1.0; | ||
| double ScheduleState::max_next_tstep(const bool enableTUNING) const { | ||
| double tuning_value = (enableTUNING && this->m_tuning.TSINIT.has_value()) ? this->m_tuning.TSINIT.value() : -1.0; | ||
| double next_value = this->next_tstep.has_value() ? this->next_tstep->value() : -1.0; | ||
| return std::max(next_value, tuning_value); |
There was a problem hiding this comment.
@vkip I know this was not part of the PR, but maybe you have an opinion on this. Should this rather be std:min instead?
Taking the maximum here at least explains why we sometimes did not see an effect of NEXTSTEP (if it was smaller than an initial TSINIT)
There was a problem hiding this comment.
Good point, std::min makes more sense I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.