[15.0][FIX] sale_timesheet_rounded: avoid recomputing rounded amounts when not needed #590
Conversation
StephaneMangin
force-pushed
the
15_fix_timesheet_rounded_when_posting_an_invoice
branch
2 times, most recently
from
a6c43eb
to
c7733aa
Compare
StephaneMangin
changed the title
StephaneMangin
force-pushed
the
15_fix_timesheet_rounded_when_posting_an_invoice
branch
7 times, most recently
from
51d9598
to
8ab89bf
Compare
|
Hi @StephaneMangin thank you for your contribution! Could you please rebase and check the tests again? |
StephaneMangin
force-pushed
the
15_fix_timesheet_rounded_when_posting_an_invoice
branch
2 times, most recently
from
67e584a
to
b673910
Compare
StephaneMangin
force-pushed
the
15_fix_timesheet_rounded_when_posting_an_invoice
branch
from
b2e191d
to
26a8b42
Compare
There was a problem hiding this comment.
Can you please:
- rewrite the 1st commit msg to include the explanation given in the description of the PR? (TIP: if you do it before, you get the description for free on the PR 😉 ). As you rewrite the commit pls drop the odoo version.
- can you explain what is the conflict in tests? We should try to avoid rebels modules as far as possible
| @@ -14,7 +14,8 @@ odoo_test_flavor: Both | |||
| odoo_version: 15.0 | |||
| org_name: Odoo Community Association (OCA) | |||
| org_slug: OCA | |||
| rebel_module_groups: [] | |||
| rebel_module_groups: | |||
| - sale_timesheet_rounded | |||
There was a problem hiding this comment.
what is the conflict in particular?
There was a problem hiding this comment.
Hello, I don't remember the exact fault, but AFAIR this was a good idea. Is this a blocking comment?
There was a problem hiding this comment.
It is, if not justified. The issue is that when we increase the number of tests suites that will run.
So, what is the conflict? Can't we find a better way to prevent that? Eg: disable partly of fully this feature when not needed?
There was a problem hiding this comment.
@sonhd91 worked on a fix for that in the context of the migration of this module to 17.0; he will backport it and follow-up here
There was a problem hiding this comment.
Hello @simahawk, here is the fix, please check it out
| @api.depends("timesheet_invoice_id.state") | ||
| def _compute_project_id(self): | ||
| field_rounded = self._fields["unit_amount_rounded"] | ||
| if self._context.get("timesheet_no_recompute", False): |
There was a problem hiding this comment.
| if self._context.get("timesheet_no_recompute", False): | |
| if self.env.context.get("timesheet_no_recompute", False): |
| _inherit = "sale.advance.payment.inv" | ||
|
|
||
| def create_invoices(self): | ||
| """Override method from sale/wizard/sale_make_invoice_advance.py |
Co-authored-by: Nils Hamerlinck <nilshamerlinck@users.noreply.github.com>
Superseed #585
This is causing the field to be set as computed, but there is no real change
We don't want to compute the field in these cases:
This is causing the field aal.project_id to be considered as computed, but it is not.
It will then call the @api.depends('project_id',...) on the computation of the unit_amount_rounded (even if there was no change on the value of aal.project_id.