FIX: compute called on project_id field when there is no change #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing the field to be set as computed, but there is no real change We don't want to compute the field in this case
StephaneMangin
approved these changes
Apr 19, 2023
Ricardoalso
approved these changes
Apr 19, 2023
|
Superseeded by #590 |
|
Closing in favor the the PR that superseeds it #590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing the field to be set as computed, but there is no real change
We don't want to compute the field in this case
To propagate the name & project_id on the aal, odoo has added https://github.com/odoo/odoo/pull/106164/files#diff-edc6b8dbe8bb37262518fb2d4e6dafd03a4aff0715a592ee1472c8d198e840ebR73
This is causing the field aal.project_id to be considered as computed, but it is not.
It will then call the
@api.depends('project_id',...)on the computation of theunit_amount_rounded(even if there was no change on the value ofaal.project_id.When we create a new invoice or delete it, we don't want to change the value of
unit_amount_rounded