-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dell XPS 15 9530 #881
Draft
bashfulrobot
wants to merge
4
commits into
NixOS:master
Choose a base branch
from
bashfulrobot:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dell XPS 15 9530 #881
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6177753
docs: Add README file for Dell XPS 15 9530
bashfulrobot c9121cc
feat: Add documentation for Goodix fingerprint
bashfulrobot 1224d0f
feat: Enable fingerprint authentication for login screen
bashfulrobot 357be71
feat: Add support for Dell XPS 15-9530 with NVIDIA graphics
bashfulrobot File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
= Dell XPS 15 9530 = | ||
|
||
== Tested Hardware == | ||
|
||
* CPU: 13th Gen Intel(R) Core(TM) i9-13900H | ||
* RAM: 32 GB | ||
* HDD: 1 TiB SSD (NVME) | ||
* Screen: 15" 4k (3456 x 2160) | ||
* Graphics: NVIDIA GeForce RTX 4070 Laptop GPU, with Intel Graphics too. | ||
* Input: Touchscreen and trackpad. | ||
* Fingerprint Reader: Goodix | ||
|
||
== Notes == | ||
|
||
== NVIDIA Offload == | ||
|
||
In order to run a program on the NVIDIA gpu, you can use the `nvidia-offload` function, for example: | ||
``` | ||
nvidia-offload `nix-shell -p glxinfo --run 'glxgears'` | ||
``` | ||
This is a short bash script that sets the proper environment variables and calls your command. | ||
|
||
== Fingerprint Reader == | ||
|
||
I have added support for the fingerprint reader. It has however been tested on Gnome only. | ||
|
||
- After Installation, I had to reboot once before the fingerprint options would showin the Users module in Gnome Settings | ||
- You will need to register your fingerprints in the Users module in Gnome Settings | ||
- When logging in I suggest using your password otherwise the keyring is not unlocked at login. You can use the fingerprint reader at all other times. | ||
|
||
== Touchpad == | ||
|
||
This is a matter of preference, but I do recommend disabling the Touchpad while typing. I hit it with my palm all the time. | ||
|
||
Since I am using Gnome, I have done this through Home-Manager using `dconf`. | ||
|
||
``` | ||
"org/gnome/desktop/peripherals/touchpad" = { | ||
disable-while-typing = true; | ||
}; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ lib, ... }: | ||
{ | ||
imports = [ | ||
../../../common/cpu/intel | ||
../../../common/pc/laptop | ||
../../../common/pc/laptop/ssd | ||
./fingerprint | ||
]; | ||
|
||
# This will save you money and possibly your life! | ||
services.thermald.enable = lib.mkDefault true; | ||
|
||
# 9530 wifi is: | ||
# > lspci | grep i Network | ||
# - 00:14.3 Network controller: Intel Corporation Raptor Lake PCH CNVi WiFi (rev 01) | ||
# > sudo lspci -vv -s 00:14.3 | ||
# 00:14.3 Network controller: Intel Corporation Raptor Lake PCH CNVi WiFi (rev 01) | ||
# Subsystem: Intel Corporation Wi-Fi 6E AX211 160MHz | ||
# | ||
# WiFi speed is slow and crashes by default (https://bugzilla.kernel.org/show_bug.cgi?id=213381) | ||
# disable_11ax - required until ax driver support is fixed | ||
# power_save - works well on this card | ||
# boot.extraModprobeConfig = '' | ||
# options iwlwifi power_save=1 disable_11ax=1 | ||
# ''; | ||
|
||
boot.extraModprobeConfig = '' | ||
options iwlwifi power_save=1 | ||
''; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,40 @@ | ||||||
{ pkgs, lib, config, ... }: { | ||||||
|
||||||
environment.systemPackages = [ | ||||||
|
||||||
]; | ||||||
|
||||||
services.fprintd = { | ||||||
enable = true; | ||||||
tod = { | ||||||
enable = true; | ||||||
driver = pkgs.libfprint-2-tod1-goodix; | ||||||
}; | ||||||
|
||||||
}; | ||||||
|
||||||
# Used to allow a password login on first login as an alternative to just a fingerprint | ||||||
security.pam.services.login.fprintAuth = false; | ||||||
# similarly to how other distributions handle the fingerprinting login | ||||||
security.pam.services.gdm-fingerprint = | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
lib.mkIf (config.services.fprintd.enable) { | ||||||
text = '' | ||||||
auth required pam_shells.so | ||||||
auth requisite pam_nologin.so | ||||||
auth requisite pam_faillock.so preauth | ||||||
auth required ${pkgs.fprintd}/lib/security/pam_fprintd.so | ||||||
auth optional pam_permit.so | ||||||
auth required pam_env.so | ||||||
auth [success=ok default=1] ${pkgs.gnome.gdm}/lib/security/pam_gdm.so | ||||||
auth optional ${pkgs.gnome.gnome-keyring}/lib/security/pam_gnome_keyring.so | ||||||
|
||||||
account include login | ||||||
|
||||||
password required pam_deny.so | ||||||
|
||||||
session include login | ||||||
session optional ${pkgs.gnome.gnome-keyring}/lib/security/pam_gnome_keyring.so auto_start | ||||||
''; | ||||||
}; | ||||||
|
||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ lib, ... }: | ||
{ | ||
imports = [ | ||
../default.nix | ||
../../../../common/gpu/nvidia/prime.nix | ||
]; | ||
|
||
hardware.nvidia.prime = { | ||
# Bus ID of the Intel GPU. | ||
intelBusId = lib.mkDefault "PCI:0:2:0"; | ||
|
||
# Bus ID of the NVIDIA GPU. | ||
nvidiaBusId = lib.mkDefault "PCI:1:0:0"; | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not obvious to me just now how this is different from what NixOS is currently doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I likely grabbed that when I was referencing other configuration examples. I should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I just tested, and this is how it affects the behaviour.
Without that line, you cannot enter a password when first logging in. It is grayed out. You "have" to use the fingerprint. But then it errors out. After the error, you can enter the password. It very much feels like a broken flow and could be confusing to some users.
By adding this, you remove the failed fingerprint error. You can then use the expected login flows (fingerprint or password). Obviously, if you log in via fingerprint (first login), you will still have to enter your keychain password at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. This is than generally broken in nixpkgs, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to reproduce this behavior on a different laptop with Gnome.