New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dell XPS 15 9530 #881
base: master
Are you sure you want to change the base?
Dell XPS 15 9530 #881
Conversation
- Add new file `dell/xps/15-9530/README.wiki` - Specify tested hardware - Add notes section - Add NVIDIA Offload section [dell/xps/15-9530/README.wiki] - Add a new file `dell/xps/15-9530/README.wiki` - Specify the tested hardware: CPU, RAM, HDD, Screen, Graphics, Input - Add a section for notes - Add a section for NVIDIA Offload
reader and Touchpad preference in Gnome Settings [dell/xps/15-9530/README.wiki] - Added documentation for Goodix fingerprint reader - Noted that the fingerprint reader has only been tested on Gnome - Mentioned that a reboot is required for fingerprint options to appear in Gnome Settings - Registered fingerprints in the Users module in Gnome Settings - Set the password as the login method to unlock the keyring - Enabled the preference to disable the Touchpad while typing - Recommended disabling the Touchpad during typing showing an example using Home-Manager and `dconf`
- Added new `default.nix` file in `dell/xps/15-9530/fingerprint` directory - Enabled `services.fprintd` service in the configuration - Set up `tod` driver for fingerprint scanner - Allowed password authentication for initial password login - Configured fingerprint authentication for GDM login screen [dell/xps/15-9530/fingerprint/default.nix] - Add a new file `default.nix` in the `dell/xps/15-9530/fingerprint` directory - Enable the `services.fprintd` service in the configuration - Set up the `tod` driver for the fingerprint scanner - Configured fingerprint authentication for the initial password login - Configure fingerprint authentication for the GDM login screen
- Added `default.nix` file for Dell XPS 15-9530 configuration - Imported necessary files for CPU, laptop, SSD, and fingerprint - Enabled thermald service - Configured iwlwifi module with power saving option - Removed commented out code for `disable_11ax` option - Added `default.nix` file for NVIDIA configuration in Dell XPS 15-9530 - Imported `default.nix` file from parent directory and NVIDIA prime configuration file - Configured `hardware.nvidia.prime` with Bus IDs of Intel and NVIDIA GPUs [dell/xps/15-9530/default.nix] - Add a new file `dell/xps/15-9530/default.nix` - Import the following files: `../../../common/cpu/intel`, `../../../common/pc/laptop`, `../../../common/pc/laptop/ssd`, and `./fingerprint` - Enable thermald service - Add configuration for iwlwifi module with `options iwlwifi power_save=1` - Remove commented out code for `disable_11ax` option [dell/xps/15-9530/nvidia/default.nix] - Added a new file `default.nix` in the directory `dell/xps/15-9530/nvidia/` - The file `default.nix` includes two imports: `../default.nix` and `../../../../common/gpu/nvidia/prime.nix` - Added a configuration for `hardware.nvidia.prime` which includes the Bus IDs of the Intel and NVIDIA GPUs.
I have become blocked on this item (troubleshooting Nvidia). I don't understand how to merge the settings properly to build out properly for this repo. I will build this out as a traditional config for now, and if another person has a 9530 (and a better experience getting the Nvidia working correctly), I will pick this back up. I defer to the community whether we should leave this open or close it out. |
|
||
# Used to allow a password login on first login as an alternative to just a fingerprint | ||
security.pam.services.login.fprintAuth = false; | ||
# similarly to how other distributions handle the fingerprinting login |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not obvious to me just now how this is different from what NixOS is currently doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I likely grabbed that when I was referencing other configuration examples. I should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I just tested, and this is how it affects the behaviour.
Without that line, you cannot enter a password when first logging in. It is grayed out. You "have" to use the fingerprint. But then it errors out. After the error, you can enter the password. It very much feels like a broken flow and could be confusing to some users.
By adding this, you remove the failed fingerprint error. You can then use the expected login flows (fingerprint or password). Obviously, if you log in via fingerprint (first login), you will still have to enter your keychain password at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. This is than generally broken in nixpkgs, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to reproduce this behavior on a different laptop with Gnome.
# Used to allow a password login on first login as an alternative to just a fingerprint | ||
security.pam.services.login.fprintAuth = false; | ||
# similarly to how other distributions handle the fingerprinting login | ||
security.pam.services.gdm-fingerprint = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security.pam.services.gdm-fingerprint = | |
security.pam.services.gdm-fingerprint = lib.mkDefault |
I am just beginning to create support for a Dell XPS 15 9530.
I am not yet done with all the code, but I wanted to start the PR to ensure my work meets the needed standards. I am basing off the 9520 and have already been testing by leveraging the
common
components directly in my local config.My first question:
The common/GPU/Nvidia component seems to overlap with what is in the wiki for Nvidia. If a person adds the Nvidia configuration from this repo, is that all the base configuration a consumer needs, or would they still need to follow the WIKI? I want to clarify that in the readme for this model. (It always confuses me with my other machines that consume from here.) For example, I will see people manually create the offload scripts in their config, but I know the Nvidia component will also do that.
Thank you.