New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
surface: linux 6.6.13 -> 6.7.6 #878
base: master
Are you sure you want to change the base?
Conversation
Fixes #877 |
Is it possible to build the kernel locally from inside the nixos-hardware repository? @stigtsp this didn't work
|
Because Running the test suite def. catches things like syntax errors, but I personally also try to use If it builds at that stage, it's (so far) always been good enough to try installing on the Surface itself — which you'll ultimately have to do to check the kernel changes are working, of course! |
@@ -5,7 +5,7 @@ let | |||
|
|||
in { | |||
imports = [ | |||
./linux-6.6.x | |||
./linux-6.7.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're not going to expose the 6.6.x .nix
files, you may as well delete them, yeah?
In the past, @Mic92 has asked people to try to minimise the number of different kernel versions that have to be maintained for any particular hardware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sound like a good idea.
I'll try to build + test this on my Surface Go tonight (GMT+12) |
kernelPatches = surfacePatches { | ||
inherit version; | ||
patchFn = ./patches.nix; | ||
}; | ||
kernelPackages = linuxPackage { | ||
inherit version kernelPatches; | ||
sha256 = "sha256-iLiefdQerU46seQRyLuNWSV1rPgVzx3zwNxX4uiCwLw="; | ||
sha256 = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty hash should be sha256-5InsDhNw0Im0RtVlre16aYCT0rfEEioY8h7bbvk9N9M=
Edit:
It looks like the linux-surface
repo needs to be pulled forward as well to:
linux-surface = fetchFromGitHub {
owner = "linux-surface";
repo = "linux-surface";
rev = "arch-6.7.6-1";
sha256 = "1f89xzzn11d25g70zqqj3ybk68g11m33qpmh0rj46nhh9bzlj4ya";
};
With that the build advances to compilation (in progress as of this edit)
Edit 2: With those changes (see this commit) I am able to successfully compile and boot into 6.7.6. I am editing from a Surface Laptop Studio with this as a nixos flake input :) Passes ad-hoc testing on this device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can bump this to arch-6.7.9-1
? That pulls in linux-surface/linux-surface@852fcb1 which has improvements to the fan profiles on the SP9.
To cherry-pick (on top of @tracteurblinde 's commit); cf462d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can bump this to
arch-6.7.9-1
? That pulls in linux-surface/linux-surface@852fcb1 which has improvements to the fan profiles on the SP9.To cherry-pick (on top of @tracteurblinde 's commit); cf462d6
not only that but also finally has working cameras again which would be nice to have
@mexisme , @onny Just though I'd share my workflow; what I do is from my flake;
Then I push that result to my surface with |
Since 6.7 is EOL, can this PR be updated to 6.8? I'm happy to test on my Surfaces :) |
Still working on this? |
Description of changes
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input