Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface: linux-surface 6.6.25 -> 6.8.6 #912

Merged
merged 3 commits into from Apr 18, 2024

Conversation

tracteurblinde
Copy link
Contributor

@tracteurblinde tracteurblinde commented Apr 13, 2024

Description of changes

Updates the surface kernel/patchset to 6.8.1 6.8.6. Replaces #878 and fixes #877.

Passes ad-hoc testing on my SLS1.

@Mic92 @mexisme @stigtsp @iwanders

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@iwanders
Copy link
Contributor

Passes smoke test on my SP9, thanks!

@stigtsp
Copy link
Member

stigtsp commented Apr 13, 2024

Can this be updated to the latest 6.8 version?

@tracteurblinde
Copy link
Contributor Author

tracteurblinde commented Apr 13, 2024

Can this be updated to the latest 6.8 version?

As in 6.8.6? I used 6.8.1 since that was the last tag in the linux-surface repo. I can see how the arch-6.8.1-1 patchset applies on 6.8.6.

Edit: Not cleanly.

@mexisme
Copy link
Contributor

mexisme commented Apr 14, 2024

Can this be updated to the latest 6.8 version?

As in 6.8.6? I used 6.8.1 since that was the last tag in the linux-surface repo. I can see how the arch-6.8.1-1 patchset applies on 6.8.6.

Edit: Not cleanly.

linix-surface does update their patches fairly quickly, and you're absolutely correct to follow their latest release rather than the official kernel's.
Because (AFAICT) linux-surface supports more versions of Surface devices than the official kernel.

@mexisme
Copy link
Contributor

mexisme commented Apr 14, 2024

Description of changes

Updates the surface kernel/patchset to 6.8.1. Replaces #878 and fixes #877.

Passes ad-hoc testing on my SLS1.

@Mic92 @mexisme @stigtsp @iwanders

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

I'm not sure if I'll get a chance to try this, this week, though I def. endorse moving to the 6.8.x series!

However, I now only have an older Surface Go, so I'm also not sure if this is as useful a testing target any more?

One additional thought is that I think 6.8.2 as well as one of 6.8.3 or 6.8.4 incl. some important regression fixes that would be very useful to have?

@tracteurblinde
Copy link
Contributor Author

tracteurblinde commented Apr 18, 2024

Updated this PR to 6.8.6

The linux-surface repo released 6.8.6 yesterday and I've updated this PR to match.

Still passes smoke testing on my SLS1.

@tracteurblinde tracteurblinde changed the title surface: linux-surface 6.6.25 -> 6.8.1 surface: linux-surface 6.6.25 -> 6.8.6 Apr 18, 2024
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Surface Laptop 4 AMD

@stigtsp
Copy link
Member

stigtsp commented Apr 18, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Apr 18, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6f976e5

@stigtsp
Copy link
Member

stigtsp commented Apr 18, 2024

@Mic92 hope you don't mind me merging in this repo :)

@mergify mergify bot merged commit 6f976e5 into NixOS:master Apr 18, 2024
3 checks passed
@stigtsp
Copy link
Member

stigtsp commented Apr 18, 2024

@tracteurblinde A minor nitpick for later, the commit messages should include a "from" verison as well. This is very useful to have when cherrypicking etc.

For example:

surface: linux-surface to 6.8.1 should be something like surface: linux 6.6.25 -> 6.8.1

Thx again! :)

@iwanders
Copy link
Contributor

Late to the party, but confirming 6.8.6 works on my SP9. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update surface-kernel to 6.7
4 participants