Skip to content

Commit

Permalink
add Automatic-Module-Name to manifest (#442)
Browse files Browse the repository at this point in the history
Should help avoid compatibility problems in the future
if users try to pull these in before we support a proper
`module-info.java`. For more details see:

http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html
  • Loading branch information
brharrington committed Jan 27, 2018
1 parent 229d434 commit 172ab31
Show file tree
Hide file tree
Showing 7 changed files with 55 additions and 0 deletions.
8 changes: 8 additions & 0 deletions servo-apache/build.gradle
@@ -1,3 +1,11 @@
dependencies {
compile project(':servo-core')
}

jar {
manifest {
attributes(
"Automatic-Module-Name": "com.netflix.servo.apache"
)
}
}
8 changes: 8 additions & 0 deletions servo-atlas/build.gradle
Expand Up @@ -7,3 +7,11 @@ dependencies {
compile "com.fasterxml.jackson.dataformat:jackson-dataformat-smile"
jmh project(':servo-core')
}

jar {
manifest {
attributes(
"Automatic-Module-Name": "com.netflix.servo.atlas"
)
}
}
8 changes: 8 additions & 0 deletions servo-aws/build.gradle
Expand Up @@ -7,3 +7,11 @@ dependencies {
checkstyle {
sourceSets = []
}

jar {
manifest {
attributes(
"Automatic-Module-Name": "com.netflix.servo.aws"
)
}
}
7 changes: 7 additions & 0 deletions servo-core/build.gradle
Expand Up @@ -17,3 +17,10 @@ pmd {
ignoreFailures = true
}

jar {
manifest {
attributes(
"Automatic-Module-Name": "com.netflix.servo.core"
)
}
}
8 changes: 8 additions & 0 deletions servo-example/build.gradle
Expand Up @@ -27,3 +27,11 @@ task(runWithAtlas, dependsOn: 'classes', type: JavaExec) {
checkstyle {
sourceSets = []
}

jar {
manifest {
attributes(
"Automatic-Module-Name": "com.netflix.servo.example"
)
}
}
8 changes: 8 additions & 0 deletions servo-graphite/build.gradle
@@ -1,3 +1,11 @@
dependencies {
compile project(':servo-core')
}

jar {
manifest {
attributes(
"Automatic-Module-Name": "com.netflix.servo.graphite"
)
}
}
8 changes: 8 additions & 0 deletions servo-tomcat/build.gradle
@@ -1,3 +1,11 @@
dependencies {
compile project(':servo-core')
}

jar {
manifest {
attributes(
"Automatic-Module-Name": "com.netflix.servo.tomcat"
)
}
}

0 comments on commit 172ab31

Please sign in to comment.