Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations):api support for gong-oauth #1770

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hassan254-prog
Copy link
Collaborator

Describe your changes

Gong recently made changes to their API. Gong-oauth now uses api_base_url_for_customer, which varies for each customer, as its base_url for proxy requests. This parameter is returned in the response of generate-customer-token when exchanging code for an access token.

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

@khaliqgant
Copy link
Member

@hassan254-prog should this still be in draft?

@hassan254-prog
Copy link
Collaborator Author

Robin had suggested I place it in draft just in case there is more work to it.

@tconlin
Copy link
Contributor

tconlin commented Mar 11, 2024

@hassan254-prog Will this automatically work for all customers? Will there ever be a situation where a sync will fail because a customer does not yet have api_base_url_for_customer defined?

@hassan254-prog
Copy link
Collaborator Author

@tconlin , according to this thread, whenever the code is exchanged for an access token during authorization, as part of data residency support, the api_base_url_for_customer will be generated and returned in response. Have you gotten the chance to test this?

@tconlin
Copy link
Contributor

tconlin commented Mar 14, 2024

@rguldener Can we bring this out of drafts?

@rguldener
Copy link
Member

@rguldener Can we bring this out of drafts?

Sure! I only suggested draft initially because there might have been more work needed. Feel free to move this forward.

@tconlin tconlin marked this pull request as ready for review March 15, 2024 15:49
@@ -753,7 +755,7 @@ gong-oauth:
disable_pkce: true
token_request_auth_method: basic
proxy:
base_url: https://api.gong.io
base_url: ${connectionConfig.api_base_url_for_customer}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned this will break existing connections that don't have the api_base_url_for_customer field populated in the connection config.

Is there a way to fall back to https://api.gong.io?

Would something like ${connectionConfig.api_base_url_for_customer || 'https://api.gong.io} work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastienbeurier , I will do some test on this and see if the platform will handle such case. Incase of any changes to the platform, I will add them to this pull request. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants