New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations):api support for gong-oauth #1770
base: master
Are you sure you want to change the base?
Conversation
@hassan254-prog should this still be in draft? |
Robin had suggested I place it in draft just in case there is more work to it. |
@hassan254-prog Will this automatically work for all customers? Will there ever be a situation where a sync will fail because a customer does not yet have |
@rguldener Can we bring this out of drafts? |
Sure! I only suggested draft initially because there might have been more work needed. Feel free to move this forward. |
packages/shared/providers.yaml
Outdated
@@ -753,7 +755,7 @@ gong-oauth: | |||
disable_pkce: true | |||
token_request_auth_method: basic | |||
proxy: | |||
base_url: https://api.gong.io | |||
base_url: ${connectionConfig.api_base_url_for_customer} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned this will break existing connections that don't have the api_base_url_for_customer
field populated in the connection config.
Is there a way to fall back to https://api.gong.io
?
Would something like ${connectionConfig.api_base_url_for_customer || 'https://api.gong.io}
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bastienbeurier , I will do some test on this and see if the platform will handle such case. Incase of any changes to the platform, I will add them to this pull request. Thank you.
Describe your changes
Gong recently made changes to their API. Gong-oauth now uses
api_base_url_for_customer
, which varies for each customer, as itsbase_url
for proxy requests. This parameter is returned in the response ofgenerate-customer-token
when exchanging code for an access token.Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)