feat(proxy):add fallback to proxy base_url #1873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassan254-prog
requested review from
khaliqgant,
bodinsamuel and
bastienbeurier
bodinsamuel
reviewed
Mar 18, 2024
| template: { | ||
| auth_mode: AuthModes.OAuth2, | ||
| proxy: { | ||
| base_url: '${connectionConfig.api_base_url_for_customer} || https://api.gong.io' |
There was a problem hiding this comment.
I don't think I have the full context but I would not go this way and add a new attributes to avoid this pseudo-js syntax. I'll let the others weigh on this
|
how many customers use the gong integration in prod. If number is small, can we coordinate with them to update their connection instead of making the providers definition and code more complicated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Continuing from this, #1770 (comment). We need to have a fallback incase
api_base_url_for_customerfield is not populated in the connection configuration. I have also added a unit test for this..