OAuth Browsable API Login #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboulware
reviewed
Jan 29, 2021
| @@ -60,15 +60,16 @@ MANAGER_IP="$(hostname -I | cut -d' ' -f1)" | |||
| # Set to OAUTH if using OAuth Password Flow Authentication, callback url needs to be api/v2/results | |||
| CALLBACK_AUTHENTICATION=TOKEN | |||
|
|
|||
| CLIENT_ID=sensor01.sms.internal | |||
| CLIENT_ID=sensor01.sms.internal # must match FQDN | |||
There was a problem hiding this comment.
Can you not just use socket.getfqdn(). Will that not work in Docker?
There was a problem hiding this comment.
Not able to get the right value in docker
|
Note the following still need to be implemented:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to log in to sensor browsable API using OAuth. The user logs in using OAuth 2 Authorization Code flow. Then the token is stored in the session.