New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PANTHEON_SITE_NAME and TERMINUS_PLUGINS to prefer variables over secrets #470
Changes from 6 commits
472ca07
adbf598
09b7a3e
7329d27
e2d6413
6ba3d7c
69fb976
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -422,12 +422,13 @@ To enable deployment of Pantheon Review Apps: | |
} | ||
``` | ||
- Run `composer install` to install the workflow to `.github/workflows` | ||
- Add the following secrets to your repository: | ||
- Add the following [variables to your GitHub repository](https://docs.github.com/en/actions/learn-github-actions/variables#creating-configuration-variables-for-a-repository): | ||
- `PANTHEON_SITE_NAME` The canonical site name in Pantheon | ||
- `TERMINUS_PLUGINS` (optional) Comma-separated list of Terminus plugins to be available | ||
- Add the following [secrets to your GitHub repository](https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/managing-development-environment-secrets-for-your-repository-or-organization#adding-secrets-for-a-repository): | ||
- `PANTHEON_TERMINUS_TOKEN` See https://pantheon.io/docs/terminus/install#machine-token | ||
- `PANTHEON_SITE_NAME` The canonical site name | ||
- `SSH_PRIVATE_KEY` A private key of a user which can push to Pantheon | ||
- `SSH_KNOWN_HOSTS` The result of running `ssh-keyscan -H codeserver.dev.$PANTHEON_SITE_ID.drush.in` | ||
- `TERMINUS_PLUGINS` (optional) Comma-separated list of Terminus plugins to be available | ||
- `PANTHEON_REVIEW_USERNAME` (optional) A username for HTTP basic auth local | ||
- `PANTHEON_REVIEW_PASSWORD` (optional) The password to lock the site with | ||
|
||
|
@@ -513,10 +514,10 @@ Requires `GITLAB_ACCESS_TOKEN` variable to be set, which is an access token with | |
- Run `composer install` | ||
- Add your Pantheon `site-name` to the last job in the new | ||
workflow file at `.github/workflows/PantheonReviewApps.yml` | ||
- Add the following secrets to your repository: | ||
- `PANTHEON_TERMINUS_TOKEN` See https://pantheon.io/docs/terminus/install#machine-token | ||
- `SSH_PRIVATE_KEY` A private key of a user which can push to Pantheon | ||
- `SSH_KNOWN_HOSTS` The result of running `ssh-keyscan -H codeserver.dev.$PANTHEON_SITE_ID.drush.in` | ||
- Add the following [variables to your GitLab repository](https://docs.gitlab.com/ee/ci/variables/#for-a-project): | ||
- `PANTHEON_TERMINUS_TOKEN` See https://pantheon.io/docs/terminus/install#machine-token (enable the _Mask variable_ checkbox) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting. GitLab uses variables, but can mask the variable! TIL. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm assuming since they were varables already for gitlab, that there isn't any change needed in the gitlab action. yeah, looks that way since https://github.com/Lullabot/drainpipe/blob/main/scaffold/gitlab/PantheonReviewApps.gitlab-ci.yml doesn't specify variable or secret. |
||
- `SSH_PRIVATE_KEY` A private key of a user which can push to Pantheon (enable the _Mask variable_ checkbox) | ||
- `SSH_KNOWN_HOSTS` The result of running `ssh-keyscan -H codeserver.dev.$PANTHEON_SITE_ID.drush.in` (enable the _Mask variable_ checkbox) | ||
- `TERMINUS_PLUGINS` Comma-separated list of Terminus plugins to be available (optional) | ||
|
||
This will setup Merge Request deployment to Pantheon Multidev environments. See | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is the gitHUB section. The hunk below is the gitLAB section.