Update PANTHEON_SITE_NAME and TERMINUS_PLUGINS to prefer variables over secrets #470
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -433,12 +433,13 @@ To enable deployment of Pantheon Review Apps: | |
| } | ||
| ``` | ||
| - Run `composer install` to install the workflow to `.github/workflows` | ||
| - Add the following [variables to your GitHub repository](https://docs.github.com/en/actions/learn-github-actions/variables#creating-configuration-variables-for-a-repository): | ||
| - `PANTHEON_SITE_NAME` The canonical site name in Pantheon | ||
| - `TERMINUS_PLUGINS` (optional) Comma-separated list of Terminus plugins to be available | ||
| - Add the following [secrets to your GitHub repository](https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/managing-development-environment-secrets-for-your-repository-or-organization#adding-secrets-for-a-repository): | ||
| - `PANTHEON_TERMINUS_TOKEN` See https://pantheon.io/docs/terminus/install#machine-token | ||
| - `SSH_PRIVATE_KEY` A private key of a user which can push to Pantheon | ||
| - `SSH_KNOWN_HOSTS` The result of running `ssh-keyscan -H codeserver.dev.$PANTHEON_SITE_ID.drush.in` | ||
| - `PANTHEON_REVIEW_USERNAME` (optional) A username for HTTP basic auth local | ||
| - `PANTHEON_REVIEW_PASSWORD` (optional) The password to lock the site with | ||
|
|
||
|
|
@@ -524,10 +525,10 @@ Requires `GITLAB_ACCESS_TOKEN` variable to be set, which is an access token with | |
| - Run `composer install` | ||
| - Add your Pantheon `site-name` to the last job in the new | ||
| workflow file at `.github/workflows/PantheonReviewApps.yml` | ||
| - Add the following [variables to your GitLab repository](https://docs.gitlab.com/ee/ci/variables/#for-a-project): | ||
| - `PANTHEON_TERMINUS_TOKEN` See https://pantheon.io/docs/terminus/install#machine-token (enable the _Mask variable_ checkbox) | ||
|
There was a problem hiding this comment. Interesting. GitLab uses variables, but can mask the variable! TIL. There was a problem hiding this comment. I'm assuming since they were varables already for gitlab, that there isn't any change needed in the gitlab action. yeah, looks that way since https://github.com/Lullabot/drainpipe/blob/main/scaffold/gitlab/PantheonReviewApps.gitlab-ci.yml doesn't specify variable or secret. |
||
| - `SSH_PRIVATE_KEY` A private key of a user which can push to Pantheon (enable the _Mask variable_ checkbox) | ||
| - `SSH_KNOWN_HOSTS` The result of running `ssh-keyscan -H codeserver.dev.$PANTHEON_SITE_ID.drush.in` (enable the _Mask variable_ checkbox) | ||
| - `TERMINUS_PLUGINS` Comma-separated list of Terminus plugins to be available (optional) | ||
|
|
||
| This will setup Merge Request deployment to Pantheon Multidev environments. See | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is the gitHUB section. The hunk below is the gitLAB section.