Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export addVariable #607

Merged
merged 1 commit into from Aug 14, 2020
Merged

export addVariable #607

merged 1 commit into from Aug 14, 2020

Conversation

dehann
Copy link
Member

@dehann dehann commented Aug 13, 2020

No description provided.

@dehann dehann added this to the v0.10.0 milestone Aug 13, 2020
@dehann dehann added the API label Aug 13, 2020
@Affie
Copy link
Member

Affie commented Aug 13, 2020

I didn't export it on purpose. I saw it as experimental. Also, still not convinced about the parameters.

@dehann
Copy link
Member Author

dehann commented Aug 13, 2020

thats fine thanks, we have to consolidate with Manifolds and must start somewhere. JuliaRobotics/RoME.jl#244 . I've wanted to do macro's for a while but just not getting around to it.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #607 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files          33       33           
  Lines        2191     2191           
=======================================
  Hits         1751     1751           
  Misses        440      440           
Impacted Files Coverage Δ
src/DistributedFactorGraphs.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a245c2e...43126a6. Read the comment docs.

@dehann dehann added types VariableType This used to be called softtype (#603) labels Aug 14, 2020
@dehann dehann merged commit 66906f1 into master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API types VariableType This used to be called softtype (#603)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants