Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip, refactoring sample to tangents #152

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dehann
Copy link
Member

@dehann dehann commented Aug 19, 2021

No description provided.

@dehann dehann added this to the v0.5.0 milestone Aug 19, 2021
@dehann dehann added the API label Aug 19, 2021
@dehann dehann added this to In progress in Change to Manifolds.jl and NearestNeighbors.jl via automation Aug 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #152 (36f76a4) into master (1169d4c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   50.14%   50.14%           
=======================================
  Files          16       16           
  Lines         702      702           
=======================================
  Hits          352      352           
  Misses        350      350           
Impacted Files Coverage Δ
src/Deprecated.jl 0.00% <ø> (ø)
src/Interface.jl 67.46% <ø> (ø)
src/services/ManifoldKernelDensity.jl 62.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1169d4c...36f76a4. Read the comment docs.

@Affie
Copy link
Member

Affie commented Aug 20, 2021

Do not merge, will probably be replaced by JuliaRobotics/IncrementalInference.jl#1359

@dehann
Copy link
Member Author

dehann commented Aug 21, 2021

Hi @Affie , shall we close this PR?

@Affie
Copy link
Member

Affie commented Aug 21, 2021

Maybe we can keep AbstractVector and comment delete part

@Affie Affie modified the milestones: v0.5.0, v0.6.0 Jun 6, 2022
@dehann dehann modified the milestones: v0.6.0, v0.0.x Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants