Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form submission: Identify pressed submit button associated through form attribute #5190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Form submission: Identify pressed submit button associated through form attribute #5190

wants to merge 1 commit into from

Conversation

raviks789
Copy link
Contributor

@raviks789 raviks789 commented Feb 20, 2024 •
edited

Issue

When there are multiple submit buttons outside the form which are associated with it as shown below, the form fails to correctly identify the pressed submit button.

<html>
  <form id="test-form">
    <input type="text" name="name"/>
    <input value="Save" name="save" type="submit">
  </form>
  
  <div>
    <button type="submit" form="test-form" name="button-1">Button 1</button>
    <button type="submit" form="test-form" name="button-2">Button 2</button>
  </div>
</html>

Solution

In case the button is undefined upon submit event, get the pressed submit button using the submitter property found on the SubmitEvent interface.

Depends on #5191.

@raviks789 raviks789 self-assigned this Feb 20, 2024
@cla-bot cla-bot bot added the cla/signed label Feb 20, 2024
@raviks789 raviks789 force-pushed the fix/multiple-external-submit-buttons branch from 22774ef to e5f0abf Compare February 20, 2024 15:36
@raviks789 raviks789 mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg Awaiting requested review from nilmerg

At least 1 approving review is required to merge this pull request.

Assignees

@raviks789 raviks789

Labels
cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@raviks789