Event rule config enhancement #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
event-rule-config-enhancement
branch
4 times, most recently
from
c40476a
to
8e16e7e
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
13 times, most recently
from
1c9054f
to
7ab548f
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
9 times, most recently
from
25b4a12
to
163112c
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
3 times, most recently
from
97018d5
to
4b1380c
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
3 times, most recently
from
2b31a5a
to
4bbe6f0
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
220a79d
to
c81fd09
Compare
sukhwinder33445
requested changes
May 14, 2024
| $buttonsWrapper->add( | ||
| [$eventRuleConfigSubmitButton, $discardChangesButton, $deleteButton] | ||
| ); | ||
| $buttonsWrapper->add([$eventRuleConfigSubmitButton, $discardChangesButton, $deleteButton]); |
There was a problem hiding this comment.
This button can then be added conditionally.
This comment is present in PR #170. You are right, it must be fixed here. |
raviks789
force-pushed
the
event-rule-config-enhancement
branch
2 times, most recently
from
6a76ace
to
3dae615
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
3 times, most recently
from
8b5bffe
to
be66793
Compare
sukhwinder33445
previously approved these changes
May 15, 2024
|
Please squash the commits. |
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
be66793
to
d31e8a6
Compare
|
Please do not forget to keep an eye on the phpstan errors. |
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
d31e8a6
to
fd35468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single form for event rule configuration.
Blocked by Icinga/icingaweb2#5190