Enhance notification types #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
from
4617a5c
to
a8cf6f4
Compare
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
from
a8cf6f4
to
f88cc25
Compare
oxzi
force-pushed
the
icinga2-source
branch
5 times, most recently
from
ae322aa
to
f99810b
Compare
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
2 times, most recently
from
1098d13
to
63c840e
Compare
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
from
63c840e
to
1127399
Compare
oxzi
force-pushed
the
icinga2-source
branch
2 times, most recently
from
97824ac
to
86c2bc0
Compare
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
4 times, most recently
from
2fb2aff
to
82bff48
Compare
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
from
b7a76cc
to
28cbafe
Compare
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
6 times, most recently
from
38b63c0
to
f193809
Compare
sukhwinder33445
force-pushed
the
support-other-notification-types
branch
2 times, most recently
from
c581ca5
to
604c883
Compare
julianbrost
reviewed
Jan 5, 2024
Comment on lines
+60
to
+70
| case TypeState: | ||
| case TypeAcknowledgement: | ||
| case TypeCommentAdded: | ||
| case TypeCommentRemoved: | ||
| case TypeDowntimeStart: | ||
| case TypeDowntimeEnd: | ||
| case TypeDowntimeCancelled: | ||
| case TypeCustom: | ||
| case TypeFlappingStart: | ||
| case TypeFlappingEnd: | ||
| return nil |
There was a problem hiding this comment.
There's no automatic fallthrough between cases, so this doesn't really do what you probably expect (or in some way it does, the next statement after switch will be the return nil at the end of the function, so you won't notice a difference here.
Hint: you can do case A, B, C:
oxzi
force-pushed
the
icinga2-source
branch
5 times, most recently
from
bb764bd
to
d6c4d36
Compare
|
I'll take over this PR from now on! |
..because it is used for both incident and non-incident states
…istory.go` Move `HistoryRow` struct to this file, as history table has also been generalised
yhabteab
force-pushed
the
support-other-notification-types
branch
from
71a6b2b
to
ddad1e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #106