Support sending non-state notifications without an incident #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
yhabteab/support-non-state-notification-types
branch
from
0431265
to
62d1ceb
Compare
yhabteab
force-pushed
the
send-incident-non-state-notifications
branch
2 times, most recently
from
796ff00
to
0ff79aa
Compare
yhabteab
force-pushed
the
yhabteab/support-non-state-notification-types
branch
5 times, most recently
from
c2743ba
to
8ba8889
Compare
yhabteab
force-pushed
the
yhabteab/support-non-state-notification-types
branch
3 times, most recently
from
b7dd933
to
68811f7
Compare
yhabteab
requested review from
oxzi and
julianbrost
and removed request for
julianbrost
|
Please review concept and functionality, but be aware that there is no corresponding web PR yet. |
yhabteab
force-pushed
the
send-incident-non-state-notifications
branch
from
8c380a1
to
e2269d2
Compare
We don't need to pass this info around methods since we can easily determine whether an incident is new based on its `StartedAt` timestamp. Co-Authored-By: Sukhwinder Dhillon <sukhwinder.dhillon@icinga.com>
We're going to use this recipient channels map elsewhere outside the `incident` package in the future and it seems reasonable to me to move it here to the `rule` package.
In the upcoming commits, this will also be used elsewhere.
In the upcoming commits, this will also be used elsewhere.
…t.Key`
This allows us to use `zap.Inline(escalation)` or
`zap.Object("escalation", escalation)`wherever more logging context is
needed without having to add all the individual fields ourselves each
time.
It will be used to determine non-state notification recipients without an incident.
Given that these configs are user-configurable, they need to be loaded regulary from the database just like the other types. I have also already taken careful consideration to deduplicate as much code as possible.
…ror type Otherwise, we will have a cyclic import error with the upcoming changes to non-state event processing support. They kind of also fit into this package.
It was already quite annoying having to return `types.Int` every single time this method was used. This commit embeds the functionality for `insert and fetch ID` directly into the `HistoryRow` type and nowhere needs to be returned. The just inserted and fetched ID can be accessed with `history.ID`.
I also replaced `errors` with `github/pkg/errors` package, is it was quite challenging to track down the errors, as we only get messages without stack traces with the standard errors package.
The `incident_event` table is now obsolete and is no longer required, and the `incident#ProcessEvent()` method has been replaced by the new `events.Router` type.
Co-Authored-By: Sukhwinder Dhillon <sukhwinder.dhillon@icinga.com>
yhabteab
force-pushed
the
yhabteab/support-non-state-notification-types
branch
from
68811f7
to
11b142c
Compare
julianbrost
reviewed
May 16, 2024
Comment on lines
+66
to
+77
| if i != nil { | ||
| if err := i.ProcessEvent(ctx, ev); err != nil { | ||
| if errors.Is(err, event.ErrSuperfluousStateChange) { | ||
| return err | ||
| } | ||
|
|
||
| // Expect the actual error to be logged with additional context in the incident package. | ||
| return event.ErrEventProcessing | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
So if an Incident exists, the other rules aren't even considered? That shouldn't be the case, if you configure that you want to be notified about downtimes, you should be notified about all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facilitates sending non-state notifications even without an active incident. See the individual commits separately for the details of why something was changed and most of them also contain their own reasons.
resolves #106
closes #137