Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(a_text_purpose, meta_viewport_zoomable, widget_tabbable_exists, widget_tabbable_single): Re-mapping WCAG SC and help references #1899

Merged
merged 8 commits into from Apr 29, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 23, 2024

Rule/Engine updates:
fixrule(a_text_purpose, meta_viewport_zoomable): Re-mapping WCAG SC

  • New Rule(s): List rule IDs
  • New or modified help files: meta_viewport_zoomable.html
  • Rule bug: a_text_purpose, meta_viewport_zoomable

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

  • test cases: test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.0.html
    Click "Learn More" for Recommendation Message: Confirm the 'meta[name=viewport]' with "maximum-scale=1.0" can be zoomed by user
  • Before fix: Two SC mappings (Requirements): IBM 1.4.4 Resize text and IBM 1.4.10 Reflow
  • After fix: only one SC mapping (Requirements): IBM 1.4.4 Resize text
  • Review the mapping in the Checker rule set for the rules mapped to 1.4.4, 1.4.10, 2.1.1 and 2..4.3. The mapping is also available in the Actions -> Artifacts: Rule listing (generated are build time)
  • Review the help text changes for the widget_tabbable_single rule

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy
Copy link
Contributor Author

@philljenkins I reviewed your changes. Please go ahead to review the rest and push to test.

@philljenkins philljenkins changed the title fixrule(a_text_purpose, meta_viewport_zoomable): Re-mapping WCAG SC fixrule(a_text_purpose, meta_viewport_zoomable, widget_tabbable_exists, widget_tabbable_single): Re-mapping WCAG SC and help references Apr 24, 2024
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code changes

@philljenkins
Copy link
Contributor

Reviewed mapping changes are correct in Action artifact Rule listing

philljenkins
philljenkins previously approved these changes Apr 24, 2024
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes and mapping reviewed and ready for QA

@ErickRenteria
Copy link
Contributor

@shunguoy we also need to remove the requirements under why is this important?
Screenshot 2024-04-29 at 12 19 48 PM

@shunguoy
Copy link
Contributor Author

@ErickRenteria fixed, thanks.

@ErickRenteria ErickRenteria added this pull request to the merge queue Apr 29, 2024
Merged via the queue into master with commit a2aec44 Apr 29, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1834 branch May 7, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment