Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(a_text_purpose) to report against (map) both 4.1.2 Name, Role, Value and 2.4.4 Link Purpose (In Context) to match ACT #1468

Closed
philljenkins opened this issue May 24, 2023 · 3 comments · Fixed by #1899
Assignees
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA SME Discuss with subject matter experts

Comments

@philljenkins
Copy link
Contributor

philljenkins commented May 24, 2023

ACT rule c487ae: Link has non-empty accessible name

This rule is implemented by the Checker using the ruleID a_text_purpose:Pass_0,Fail_1 procedure. The implementation is partially consistent with the Link has non-empty accessible name WCAG 2 rule as reported results last updated 16 May 2023.

Although it correctly covers all 28 test cases, the Checker mapping reports different success criteria as failed from what is expected by the ACT rule. ACT expects both:
4.1.2 Name, Role, Value
2.4.4 Link Purpose (In Context)
while Checker ruleID a_text_purpose only reports against 2.4.4

rulesets: [{
id: [ "IBM_Accessibility", "WCAG_2_0", "WCAG_2_1"],
num: "2.4.4", // num: [ "2.4.4", "x.y.z" ] also allowed
level: eRulePolicy.VIOLATION,
toolkitLevel: eToolkitLevel.LEVEL_TWO
}],
act: "c487ae",

This issue is to update the mapping to the same SC's as ACT.

@philljenkins philljenkins added engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts priority-2 (med) labels May 24, 2023
@philljenkins philljenkins self-assigned this May 24, 2023
@philljenkins philljenkins added the ACT Issues/Rules related to ACT label May 30, 2023
@marcjohlic
Copy link
Member

Removed sprint and release info because this issue has not been triaged yet. Added to the ACT Issue Holder epic.

@marcjohlic
Copy link
Member

Adding this to the R6.1 Rules epic rather than creating a new R6.1 ACT Issue epic for the two late ACT issues that were pulled in. Leaving the issue holder on these two issues for now as a reminder that they were ACT issues that were pulled in at the end of the release.

@shunguoy
Copy link
Contributor

PR: #1899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA SME Discuss with subject matter experts
Projects
None yet
4 participants