Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(meta_viewport_zoomable) to report against (map) only 1.4.4 Resize text and not 1.4.10 Reflow to match ACT #1469

Closed
philljenkins opened this issue May 24, 2023 · 6 comments · Fixed by #1899
Assignees
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA SME Discuss with subject matter experts

Comments

@philljenkins
Copy link
Contributor

ACT rule b4f0c3: Meta viewport allows for zoom

This rule is implemented by the Checker using the meta_viewport_zoomable:Pass_0,Potential_1 procedure. The implementation is partially consistent with the Meta viewport allows for zoom ACT WCAG 2 rule. The test results were last updated 16 May 2023.

Although it correctly covers all 11 test cases, the Checker mapping reports different success criteria as failed from what is expected by the ACT rule. ACT expects only one SC:
1.4.4 Resize text
while the Checker ruleID meta_viewport_zoomable reports against two SCs:
1.4.4 Resize text
1.4.10 Reflow

rulesets: [{
"id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_0"],
"num": ["1.4.4"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_THREE
},
{
"id": ["IBM_Accessibility", "WCAG_2_1"],
"num": ["1.4.10"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_THREE
}],
act: [{
"b4f0c3": {
"Pass_0": "pass",
"Potential_1": "fail"
}

This issue is to update the mapping to the same SC's as ACT.

@philljenkins philljenkins added engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts priority-2 (med) labels May 24, 2023
@philljenkins philljenkins self-assigned this May 24, 2023
@philljenkins
Copy link
Contributor Author

philljenkins commented May 24, 2023

Consider changing the eRulePolicy: RECOMMENDATION to a VIOLATION and keep the Potential_1 reason so it maps to
NEEDS REVIEW when reporting in the Checker
messages: {
"en-US": {
"group": "The 'meta[name=viewport]' should not prevent the browser zooming the content",
"Pass_0": "The 'meta[name=viewport]' does not prevent the browser zooming the content",
"Potential_1": "Confirm the 'meta[name=viewport]' with \"{0}\" can be zoomed by user"
}

@philljenkins
Copy link
Contributor Author

philljenkins commented May 24, 2023

Consider if style_viewport_resizable
is a better rule to map to ACT since it checks text resize

messages: {
"en-US": {
"group": "Text must scale up to 200% without loss of content or functionality",
"Pass_0": "Rule Passed",
"Potential_1": "Verify that text sized using viewport units can be resized up to 200%"
}
},
rulesets: [{
id: ["IBM_Accessibility", "WCAG_2_0", "WCAG_2_1"],
num: "1.4.4", // num: [ "2.4.4", "x.y.z" ] also allowed
level: eRulePolicy.VIOLATION,
toolkitLevel: eToolkitLevel.LEVEL_THREE
}],
act: [],

But Checker ruleID meta_viewport_zoomable does trigger fail for the above test cases.

@marcjohlic
Copy link
Member

Removed sprint and release info because this issue has not been triaged yet. Added to the ACT Issue Holder epic.

@shunguoy
Copy link
Contributor

shunguoy commented Jun 5, 2023

triage: should change the 'potential' to 'failure' to map ACT.

@marcjohlic
Copy link
Member

Adding this to the R6.1 Rules epic rather than creating a new R6.1 ACT Issue epic for the two late ACT issues that were pulled in. Leaving the issue holder on these two issues for now as a reminder that they were ACT issues that were pulled in at the end of the release.

@shunguoy
Copy link
Contributor

PR: #1899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA SME Discuss with subject matter experts
Projects
None yet
4 participants