Add gruvbox base theme and gruvbox green color theme #4805
Conversation
github-actions
bot
added
the
PR: waiting for review
|
Ah, lint. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
Also this doesnt fully close the issue because you didnt implement all the gruvbox colors listed in their repo https://github.com/morhetz/gruvbox. The issue also explicitly asks for the light and dark theme implementation. Would you be open to implementing all the other colors and both themes? |
|
Yes, I will implement both light and dark, I was just checking if this pr is appropriate. I'll fix the secondary colour issue right now, |
Head branch was pushed to by a user without write access
… add the opacity1 - 4
Head branch was pushed to by a user without write access
|
Ok, so the reason the secondary colours were not working properaly was because I did not add the "--accent-color-opacity1 - 4" so I added that and I think it's fixed though I haven't added the gruv light theme yet. |
|
By the way, I'm not sure how to make the icons for it so mine were a bit thrown together and look not great, so yeah. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
…uvbox (and fixed lint)
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Hmmm, Lint says there's no issues on my machine. |
Head branch was pushed to by a user without write access
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
@DeaDvey Could you please rebase/merge with development one more time and remove the changes to |
Head branch was pushed to by a user without write access
DeaDvey
dismissed
efb4f5ff-1298-471a-8973-3d47447115dc’s stale review
via
318a9ec
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sorry that I took a while, I'm quite busy at the moment. |
|
I get an error saying there is no portal-vue. in node_modules |
|
Run |
|
Oh yeah, thanks that worked, the themes all show correctly, solarized looks great too! 👍 |
There was a problem hiding this comment.
Fix poor contrast issues:
- https://coolors.co/contrast-checker/fb4934-282828
- https://coolors.co/contrast-checker/b8bb26-fbf1c7
- https://coolors.co/contrast-checker/fb4934-fbf1c7
- https://coolors.co/contrast-checker/fabd2f-fbf1c7
- https://coolors.co/contrast-checker/83a598-fbf1c7
- https://coolors.co/contrast-checker/d3869b-fbf1c7
- https://coolors.co/contrast-checker/8ec07c-fbf1c7
- https://coolors.co/contrast-checker/fe8019-fbf1c7
@jasonhenriquez do you have suggestions to handle this in the best possible way?
|
Thanks for identifying these @efb4f5ff-1298-471a-8973-3d47447115dc. Seems like |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Hi @DeaDvey, just checking in to make sure you're alright. I want to make sure the required suggestion and how to implement & validate it are clear enough. |
|
Yeah, I'm a bit busy right now but I should be able to have a look at it tomorrow. |
Add gruvbox base theme and gruvbox green color theme
Pull Request Type
Related issue
Closes #3987
Description
I added a gruvbox base theme using the gruvbox colour palette as well as a gruvbox green color theme, I will add more of the color themes if the pr is accepted
Screenshots
Testing
I tested it and I cannot see any issues with the color schemes showing though I have not added all the translations as I only speak english.
Desktop
Additional context
I wanted a gruvbox theme for FreeTube and I saw that another issue request did too, it's fine if you (the developers) don't, I was just opening this pr incase it was appropriate.