Make adding themes easier

[jasonhenriquez]

Make adding themes easier

Pull Request Type

• Other - Code Cleanup

Related issue

#5066 (comment)

Description

Changes (no behavioral changes):

• Adds code commenting to better explain and delineate themes.css sections
• Moves Invidious and YT logo theme logic to be in themes.css as opposed to the ft-share-button.scss file (most contributors don't think to check here, and for good reason)
• Simplifies destructive color collision logic to check for "Red" or "Purple" in theme color name
• Simplifies rules in 3 cases to reduce manual effort & better clarify purpose

Fixes:

• Fixes Invidious / YT logo colors for Nordic and Dracula base themes

Testing

• REG: test destructive colors change properly for red theme color and red+purple theme color cases
• REG: test Invidious / YT logos appear properly on any given light or dark theme on the share button (e.g., on a Channel page)
• (Optional) REG: sanity test a light theme, dark theme, and hot pink theme

Desktop

• OS: OpenSUSE
• OS Version: TW

[jasonhenriquez]

I requested a tentative review, but I do want #4805 and #5066 merged first just to minimize frustration for the authors.

[PikachuEXE]

Maybe re-request review (leave a comment) after those are merged? (I will forget this PR in < 5 minutes

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[jasonhenriquez]

I'm seeing that the authors of PRs #4293 and #4805 are still working on their changes. I'll give it another couple weeks before I move forward with these changes.